This repository has been archived by the owner on Dec 20, 2024. It is now read-only.
feature: get LocalIP from supernode HTTP _ping API first rather than … #1402
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…TCP connection due to Kube-service in ipvs-mod will get cluster IP for LocalAddr Signed-off-by: komey <[email protected]>
Signed-off-by: komey <[email protected]>
Signed-off-by: komey <[email protected]>
allencloud
reviewed
Jul 6, 2020
| if code, body, e = api.HTTPClient.Get(url, api.Timeout); e != nil { | ||
| return "", e | ||
| } | ||
| if !httputils.HTTPStatusOk(code) { |
There was a problem hiding this comment.
Is the StatusOK(200) the only case to judge whether a node could be pinged?
I don't think we should use HTTP protocol (which is level 7) to test the connection.
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
feature: get LocalIP from supernode HTTP _ping API first rather than TCP connection due to Kube-service in ipvs-mod will get cluster IP for LocalAddr
Ⅰ. Describe what this PR did
Ⅱ. Does this pull request fix one issue?
fixes #1399
Ⅲ. Why don't you add test cases (unit test/integration test)? (你真的觉得不需要加测试吗？)
×
Ⅳ. Describe how to verify it
Connect to supernode get self IP: %sⅤ. Special notes for reviews