Skip to content
This repository has been archived by the owner on Dec 20, 2024. It is now read-only.

add docs for cri-o registry mirror #1440

Merged
merged 4 commits into from
Sep 4, 2020

Conversation

jim3ma
Copy link
Member

@jim3ma jim3ma commented Jul 23, 2020

Signed-off-by: 楚贤 [email protected]

Ⅰ. Describe what this PR did

add docs for cri-o registry mirror configuration.

Ⅱ. Does this pull request fix one issue?

fix #1419

Ⅲ. Why don't you add test cases (unit test/integration test)? (你真的觉得不需要加测试吗?)

N/A

Ⅳ. Describe how to verify it

N/A

Ⅴ. Special notes for reviews

N/A

@pouchrobot
Copy link
Collaborator

Thanks for your contribution. 🍻 @jim3ma
While we thought PR TITLE could be more specific, longer than 20 chars.
Please edit this PR title instead of opening a new one.
More details, please refer to https://github.com/dragonflyoss/Dragonfly/blob/master/CONTRIBUTING.md

@jim3ma jim3ma changed the title add docs for cri-o add docs for cri-o registry mirror Jul 23, 2020
Signed-off-by: 楚贤 <[email protected]>
@@ -0,0 +1,65 @@
# Use Dfdaemon as Registry Mirror for CRI-O
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

How about adding a sub dir for using-docs for all container engines?

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

OK, but we need prepare environment for all container engines testing, it may be cost lost of time.

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think we do not need to test for each container engine. If the community has corresponding needs, we are more inclined to welcome members of the community to complete it. However, we should manage it all together.

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good suggestions

@pouchrobot pouchrobot added size/L and removed size/M labels Aug 18, 2020
@pouchrobot pouchrobot added size/L and removed size/L labels Aug 19, 2020
@jim3ma
Copy link
Member Author

jim3ma commented Aug 19, 2020

@starnop PTAL

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

How to use Dragonfly with CRI-O?
4 participants