-
Notifications
You must be signed in to change notification settings - Fork 773
Conversation
Thanks for your contribution. 🍻 @jim3ma |
Signed-off-by: 楚贤 <[email protected]>
550a668
to
a2badc9
Compare
docs/user_guide/crio_mirror.md
Outdated
@@ -0,0 +1,65 @@ | |||
# Use Dfdaemon as Registry Mirror for CRI-O |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
How about adding a sub dir for using-docs for all container engines?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
OK, but we need prepare environment for all container engines testing, it may be cost lost of time.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think we do not need to test for each container engine. If the community has corresponding needs, we are more inclined to welcome members of the community to complete it. However, we should manage it all together.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Good suggestions
Signed-off-by: 楚贤 <[email protected]>
Signed-off-by: 楚贤 <[email protected]>
Signed-off-by: 楚贤 <[email protected]>
@starnop PTAL |
Signed-off-by: 楚贤 [email protected]
Ⅰ. Describe what this PR did
add docs for cri-o registry mirror configuration.
Ⅱ. Does this pull request fix one issue?
fix #1419
Ⅲ. Why don't you add test cases (unit test/integration test)? (你真的觉得不需要加测试吗?)
N/A
Ⅳ. Describe how to verify it
N/A
Ⅴ. Special notes for reviews
N/A