This repository has been archived by the owner on Dec 20, 2024. It is now read-only.
add preheat implements #1456
Merged
add preheat implements #1456
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: 玉海 <[email protected]>
Signed-off-by: 玉海 <[email protected]>
Signed-off-by: 玉海 <[email protected]>
Signed-off-by: 玉海 <[email protected]>
|
@jim3ma PTAL. Thanks. |
starnop
reviewed
Aug 18, 2020
| @@ -60,8 +61,8 @@ func (s *Server) getPreheatTask(ctx context.Context, rw http.ResponseWriter, req | |||
| } | |||
| resp := types.PreheatInfo{ | |||
| ID: task.ID, | |||
| FinishTime: strfmt.NewDateTime(), | |||
| StartTime: strfmt.NewDateTime(), | |||
| FinishTime: strfmt.DateTime(time.Unix(task.FinishTime/1000, task.FinishTime%1000*int64(time.Millisecond)).UTC()), | |||
There was a problem hiding this comment.
Change type of FinishTime form int64 to time.Time? WDYT? So do with StartTime.
starnop
reviewed
Aug 18, 2020
| ) | ||
|
|
||
| const( | ||
| EXPIRED_TIME = 7 * 24 * 3600 * 1000; |
There was a problem hiding this comment.
Please add a comment here.
starnop
reviewed
Aug 18, 2020
| } | ||
|
|
||
| func(r *PreheatTaskRepository) load() { | ||
| r.loaded.Do(func(){ |
starnop
reviewed
Aug 18, 2020
|
|
||
| func init() { | ||
| RegisterPreheater("file", &FilePreheat{BasePreheater:new(BasePreheater)}) | ||
| logrus.StandardLogger().SetLevel(logrus.DebugLevel) |
| } | ||
|
|
||
| func (svc *PreheatService) createCommand(url string, header map[string]string, filter, identifier, tmpTarget string) *exec.Cmd { | ||
| netRate := 50 |
There was a problem hiding this comment.
please don't use magic numbers? It is easy to make others confused.
Signed-off-by: 玉海 <[email protected]>
Signed-off-by: 玉海 <[email protected]>
|
agree |
wuchaojing
pushed a commit
to wuchaojing/Dragonfly
that referenced
this pull request
Aug 26, 2020
add preheat implements
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.