Skip to content
This repository has been archived by the owner on Dec 20, 2024. It is now read-only.

feature: use util.LockerPool instead of local storage locker #575

Merged
merged 1 commit into from
Jun 3, 2019

Conversation

starnop
Copy link
Contributor

@starnop starnop commented Jun 3, 2019

Signed-off-by: Starnop [email protected]

Ⅰ. Describe what this PR did

Ⅱ. Does this pull request fix one issue?

Ⅲ. Why don't you add test cases (unit test/integration test)? (你真的觉得不需要加测试吗?)

Ⅳ. Describe how to verify it

Ⅴ. Special notes for reviews

@codecov-io
Copy link

Codecov Report

Merging #575 into master will decrease coverage by 0.12%.
The diff coverage is 80%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master     #575      +/-   ##
==========================================
- Coverage   48.18%   48.05%   -0.13%     
==========================================
  Files          96       96              
  Lines        5294     5275      -19     
==========================================
- Hits         2551     2535      -16     
+ Misses       2550     2549       -1     
+ Partials      193      191       -2
Impacted Files Coverage Δ
supernode/store/local_storage.go 72.14% <80%> (-2.08%) ⬇️
supernode/daemon/mgr/scheduler/manager.go 25.98% <0%> (+0.78%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update af58f58...6df0378. Read the comment docs.

@lowzj
Copy link
Member

lowzj commented Jun 3, 2019

LGTM

@lowzj lowzj merged commit 496c85e into dragonflyoss:master Jun 3, 2019
starnop pushed a commit to starnop/Dragonfly that referenced this pull request Nov 27, 2019
feature: use util.LockerPool instead of local storage locker
inoc603 pushed a commit to inoc603/Dragonfly that referenced this pull request Dec 23, 2019
feature: use util.LockerPool instead of local storage locker
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants