Skip to content
This repository has been archived by the owner on Dec 20, 2024. It is now read-only.

cleanup: fix typos in root.go and dfget.md #821

Merged
merged 1 commit into from
Aug 15, 2019

Conversation

beautytiger
Copy link
Contributor

Signed-off-by: Guangming Wang [email protected]

Ⅰ. Describe what this PR did

cleanup misspelled words

Ⅱ. Does this pull request fix one issue?

Ⅲ. Why don't you add test cases (unit test/integration test)? (你真的觉得不需要加测试吗?)

no need

Ⅳ. Describe how to verify it

Ⅴ. Special notes for reviews

cleanup: fix typos in dfget.md

Signed-off-by: Guangming Wang <[email protected]>
@codecov-io
Copy link

codecov-io commented Aug 15, 2019

Codecov Report

Merging #821 into master will not change coverage.
The diff coverage is 100%.

Impacted file tree graph

@@           Coverage Diff           @@
##           master     #821   +/-   ##
=======================================
  Coverage   40.05%   40.05%           
=======================================
  Files         108      108           
  Lines        6356     6356           
=======================================
  Hits         2546     2546           
  Misses       3603     3603           
  Partials      207      207
Impacted Files Coverage Δ
cmd/dfget/app/root.go 65.24% <100%> (ø) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update dbb029d...92b0123. Read the comment docs.

@beautytiger beautytiger changed the title WIP: cleanup: fix typos in root.go cleanup: fix typos in root.go Aug 15, 2019
Copy link
Collaborator

@yeya24 yeya24 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@beautytiger beautytiger changed the title cleanup: fix typos in root.go cleanup: fix typos in root.go and dfget.md Aug 15, 2019
@starnop
Copy link
Contributor

starnop commented Aug 15, 2019

LGTM.

@starnop starnop merged commit b2fd8ee into dragonflyoss:master Aug 15, 2019
starnop added a commit to starnop/Dragonfly that referenced this pull request Nov 27, 2019
cleanup: fix typos in root.go and dfget.md
inoc603 pushed a commit to inoc603/Dragonfly that referenced this pull request Dec 23, 2019
cleanup: fix typos in root.go and dfget.md
sungjunyoung pushed a commit to sungjunyoung/Dragonfly that referenced this pull request May 8, 2022
…oss#821)

* sort ip list, Place the list of IP addresses retrieved by hostname first

Signed-off-by: 孙伟鹏 <[email protected]>

* chore: fix typo

Signed-off-by: sunwp <[email protected]>
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants