Adjust the word order of comments #947
Conversation
Signed-off-by: yuxiaobo <[email protected]>
Codecov Report
@@ Coverage Diff @@
## master #947 +/- ##
==========================================
+ Coverage 46.45% 46.47% +0.01%
==========================================
Files 114 114
Lines 6737 6737
==========================================
+ Hits 3130 3131 +1
Misses 3351 3351
+ Partials 256 255 -1
Continue to review full report at Codecov.
|
dfdaemon/config/config.go
Outdated
| @@ -364,7 +364,7 @@ func certPoolFromFiles(files ...string) (*x509.CertPool, error) { | |||
| return roots, nil | |||
| } | |||
|
|
|||
| // Proxy describe a regular expression matching rule for how to proxy a request | |||
| // Proxy describes a regular expression matching rule for how to proxy a request | |||
There was a problem hiding this comment.
I think there should be a dot at the end of comment // Proxy describes a regular expression matching rule for how to proxy a request -> // Proxy describes a regular expression matching rule for how to proxy a request . ,it will be better? the other comment are the same
There was a problem hiding this comment.
I think the same as you think, but there are too many comments that don't have the dot.
I am going to add the dot together for these comments in the next pr.
There was a problem hiding this comment.
It's OK to fix this comment in this PR. THX. 😄
dfdaemon/proxy/proxy.go
Outdated
| @@ -188,7 +188,7 @@ func (proxy *Proxy) mirrorRegistry(w http.ResponseWriter, r *http.Request) { | |||
| } | |||
|
|
|||
| // remoteConfig returns the tls.Config used to connect to the given remote host. | |||
| // If the host should not be hijacked, nil will be returned. | |||
| // If the host should not be hijacked, it will return nil. | |||
There was a problem hiding this comment.
Please add a conjunction after the comma.
dfdaemon/config/config.go
Outdated
| @@ -364,7 +364,7 @@ func certPoolFromFiles(files ...string) (*x509.CertPool, error) { | |||
| return roots, nil | |||
| } | |||
|
|
|||
| // Proxy describe a regular expression matching rule for how to proxy a request | |||
| // Proxy describes a regular expression matching rule for how to proxy a request | |||
There was a problem hiding this comment.
It's OK to fix this comment in this PR. THX. 😄
Signed-off-by: yuxiaobo <[email protected]>
|
I have already modified in the pr. |
|
/assign @starnop |
|
LGTM. |
Adjust the word order of comments
Adjust the word order of comments
Signed-off-by: yuxiaobo [email protected]
Ⅰ. Describe what this PR did
Adjust the word order of comments.
Ⅱ. Does this pull request fix one issue?
NONE
Ⅲ. Why don't you add test cases (unit test/integration test)? (你真的觉得不需要加测试吗？)
Don't need.
Ⅳ. Describe how to verify it
Ⅴ. Special notes for reviews