bugfix:fix debug mod and homedir config in yaml

[yunfeiyanggzq]

Signed-off-by: yunfeiyangbuaa [email protected]

Ⅰ. Describe what this PR did

we can't config debug mod and homedir in yaml file because init config after init log and use option to config the log instead of cfg

Ⅱ. Does this pull request fix one issue?

Ⅲ. Why don't you add test cases (unit test/integration test)? (你真的觉得不需要加测试吗？)

Ⅳ. Describe how to verify it

the yaml file is

base:
  listenPort: 9002
  downloadPort: 9001
  advertiseIP: 102.168.50.156
  failAccessInterval: 2m0s
  gcInitialDelay: 3s
  gcMetaInterval: 10m0s
  taskExpireTime: 2m0s
  peerGCDelay: 100m0s
  gcDiskInterval: 120s
  debug: true

the command is

sudo go run main.go --config /home/yunfeiyang/yml/supernode.yml --port 8090 --advertise-ip 127.0.0.2
the config result is

2019-10-10 15:35:44.417 DEBU sign:16151 : get supernode config: base:
  listenPort: 8090
  downloadPort: 9001
  homeDir: /home/admin/supernode
  schedulerCorePoolSize: 10
  downloadPath: /home/admin/supernode/repo/download
  peerUpLimit: 5
  peerDownLimit: 4
  eliminationLimit: 5
  failureCountLimit: 5
  linkLimit: 20480GB
  systemReservedBandwidth: 20480GB
  maxBandwidth: 204800GB
  enableProfiler: false
  debug: true
  advertiseIP: 127.0.0.2
  failAccessInterval: 2m0s
  gcInitialDelay: 3s
  gcMetaInterval: 10m0s
  taskExpireTime: 2m0s
  peerGCDelay: 1h40m0s
  gcDiskInterval: 2m0s
  youngGCThreshold: 100GB
  fullGCThreshold: 5GB
  IntervalThreshold: 2h0m0s
  cleanratio: 1
plugins: {}
storages: {}

Ⅴ. Special notes for reviews

[codecov-io]

Codecov Report

Merging #990 into master will not change coverage.
The diff coverage is 0%.

@@           Coverage Diff           @@
##           master     #990   +/-   ##
=======================================
  Coverage   46.93%   46.93%           
=======================================
  Files         115      115           
  Lines        6954     6954           
=======================================
  Hits         3264     3264           
  Misses       3434     3434           
  Partials      256      256

Impacted Files	Coverage Δ
cmd/supernode/app/root.go	68.85% <0%> (ø)	⬆️
...get/core/downloader/p2p_downloader/power_client.go	52.17% <0%> (ø)	⬆️

---

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update f4870ac...fe078b1. Read the comment docs.

[yunfeiyanggzq]

@starnop @lowzj emmmm,I find supernode init log before init config in previous code
I make init config before init log so we can set log mod in debug mod.
but, if init config goes wrong like ERRO[0000] failed to init properties: open /etc/dragonfly/supernode.yml: no such file or directory can't bean written to log and it will print in cli.do you have some good idea

[yeya24]

Actually I don' t think it is a good idea to support debug in both config file and startup flags. For simplicity in one place is enough.

[starnop]

@starnop @lowzj emmmm,I find supernode init log before init config in previous code
I make init config before init log so we can set log mod in debug mod.
but, if init config goes wrong like ERRO[0000] failed to init properties: open /etc/dragonfly/supernode.yml: no such file or directory can't bean written to log and it will print in cli.do you have some good idea

Maybe you could make a reload.

[yunfeiyanggzq]

@starnop please review this pr again

[starnop]

Could you please rebase the code? And please pay attention the comment here.

[yunfeiyanggzq]

Done @starnop

[starnop]

LGTM>