-
Notifications
You must be signed in to change notification settings - Fork 297
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix: update get and delete task unit test and e2e test. #3525
fix: update get and delete task unit test and e2e test. #3525
Conversation
Signed-off-by: Asklv <[email protected]>
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #3525 +/- ##
==========================================
+ Coverage 51.72% 51.98% +0.26%
==========================================
Files 190 190
Lines 20424 20432 +8
==========================================
+ Hits 10564 10622 +58
+ Misses 9058 9000 -58
- Partials 802 810 +8
Flags with carried forward coverage won't be shown. Click here to find out more. |
3fcb715
to
7b2d609
Compare
Signed-off-by: Asklv <[email protected]>
7b2d609
to
ac2ae76
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Add failed case.
Signed-off-by: Asklv <[email protected]>
1f3b015
to
3f56293
Compare
Signed-off-by: Asklv <[email protected]>
3f56293
to
6bc9e20
Compare
Signed-off-by: Asklv <[email protected]>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
Description
This PR focuses on improving the unit tests for the
manager/job/task.go
and rewriting the e2e tests. The key changes are:Unit Test Rewrite (
manager/job/task.go
):End-to-End (e2e) Tests:
Related Issue
Motivation and Context
The previous unit and e2e tests were either lacking sufficient coverage or not thoroughly validating the expected outcomes. This PR enhances the testing suite by:
Refactoring the unit tests to cover more edge cases.
Introducing e2e tests that assert the correctness of return values and ensure the stability of critical functionalities.
These improvements will help catch bugs earlier and ensure that task creation and deletion APIs behave correctly in both isolated unit tests and integrated environments.
Screenshots (if appropriate)
Types of changes
Checklist