Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: support set max threads #3537

Merged
merged 1 commit into from
Sep 25, 2024
Merged

feat: support set max threads #3537

merged 1 commit into from
Sep 25, 2024

Conversation

jim3ma
Copy link
Member

@jim3ma jim3ma commented Sep 25, 2024

Description

Related Issue

Motivation and Context

Screenshots (if appropriate)

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)
  • Documentation Update (if none of the other choices apply)

Checklist

  • My change requires a change to the documentation.
  • I have updated the documentation accordingly.
  • I have read the CONTRIBUTING document.
  • I have added tests to cover my changes.

@jim3ma jim3ma requested a review from a team as a code owner September 25, 2024 08:03
Copy link

codecov bot commented Sep 25, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 51.99%. Comparing base (c9180af) to head (8326d50).
Report is 1 commits behind head on main.

Additional details and impacted files

Impacted file tree graph

@@            Coverage Diff             @@
##             main    #3537      +/-   ##
==========================================
- Coverage   52.04%   51.99%   -0.05%     
==========================================
  Files         190      190              
  Lines       20434    20434              
==========================================
- Hits        10634    10625       -9     
- Misses       8994     9000       +6     
- Partials      806      809       +3     
Flag Coverage Δ
unittests 51.99% <ø> (-0.05%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

Files with missing lines Coverage Δ
client/config/peerhost.go 47.46% <ø> (ø)

... and 3 files with indirect coverage changes

Copy link
Member

@gaius-qi gaius-qi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@gaius-qi gaius-qi merged commit 61c3cf4 into main Sep 25, 2024
29 checks passed
@gaius-qi gaius-qi deleted the feat/support-set-max-threads branch September 25, 2024 10:37
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants