Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: add fsm for persistent cache peer #3563

Merged
merged 1 commit into from
Oct 9, 2024
Merged

feat: add fsm for persistent cache peer #3563

merged 1 commit into from
Oct 9, 2024

Conversation

gaius-qi
Copy link
Member

@gaius-qi gaius-qi commented Oct 9, 2024

Description

Related Issue

Motivation and Context

Screenshots (if appropriate)

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)
  • Documentation Update (if none of the other choices apply)

Checklist

  • My change requires a change to the documentation.
  • I have updated the documentation accordingly.
  • I have read the CONTRIBUTING document.
  • I have added tests to cover my changes.

@gaius-qi gaius-qi added the enhancement New feature or request label Oct 9, 2024
@gaius-qi gaius-qi added this to the v2.2.0 milestone Oct 9, 2024
@gaius-qi gaius-qi self-assigned this Oct 9, 2024
@gaius-qi gaius-qi requested a review from a team as a code owner October 9, 2024 10:26
Copy link

codecov bot commented Oct 9, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 49.73%. Comparing base (8b6e40f) to head (692cf2d).
Report is 1 commits behind head on main.

Additional details and impacted files

Impacted file tree graph

@@           Coverage Diff           @@
##             main    #3563   +/-   ##
=======================================
  Coverage   49.73%   49.73%           
=======================================
  Files         186      186           
  Lines       19527    19527           
=======================================
  Hits         9712     9712           
- Misses       9019     9020    +1     
+ Partials      796      795    -1     
Flag Coverage Δ
unittests 49.73% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

Files with missing lines Coverage Δ
scheduler/resource/standard/peer.go 71.98% <ø> (ø)

... and 1 file with indirect coverage changes

@gaius-qi gaius-qi requested a review from a team as a code owner October 9, 2024 12:02
@gaius-qi gaius-qi requested a review from bergwolf October 9, 2024 12:02
Copy link
Member

@chlins chlins left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@gaius-qi gaius-qi merged commit 1198c98 into main Oct 9, 2024
26 of 27 checks passed
@gaius-qi gaius-qi deleted the feature/peer branch October 9, 2024 12:05
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants