Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: implement delete persistent cache task in scheduler #3619

Merged
merged 1 commit into from
Oct 29, 2024

Conversation

gaius-qi
Copy link
Member

@gaius-qi gaius-qi commented Oct 29, 2024

Description

This pull request adds an isgomock struct to various mock types across multiple files to improve the mock object structure. The most important changes include updates to mock types in different components of the project.

Updates to mock types:

These changes ensure consistency and improve the maintainability of mock objects across the codebase.

Related Issue

Motivation and Context

Screenshots (if appropriate)

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)
  • Documentation Update (if none of the other choices apply)

Checklist

  • My change requires a change to the documentation.
  • I have updated the documentation accordingly.
  • I have read the CONTRIBUTING document.
  • I have added tests to cover my changes.

@gaius-qi gaius-qi added the enhancement New feature or request label Oct 29, 2024
@gaius-qi gaius-qi added this to the v2.2.0 milestone Oct 29, 2024
@gaius-qi gaius-qi self-assigned this Oct 29, 2024
@gaius-qi gaius-qi requested a review from a team as a code owner October 29, 2024 13:24
Copy link

codecov bot commented Oct 29, 2024

Codecov Report

Attention: Patch coverage is 0% with 138 lines in your changes missing coverage. Please review.

Project coverage is 35.57%. Comparing base (c1ed128) to head (3e4dcc0).
Report is 1 commits behind head on main.

Files with missing lines Patch % Lines
scheduler/resource/persistentcache/peer_manager.go 0.00% 71 Missing ⚠️
...uler/resource/persistentcache/peer_manager_mock.go 0.00% 17 Missing ⚠️
scheduler/scheduler.go 0.00% 15 Missing ⚠️
scheduler/resource/persistentcache/task_manager.go 0.00% 12 Missing ⚠️
scheduler/resource/persistentcache/host_manager.go 0.00% 8 Missing ⚠️
...uler/resource/persistentcache/host_manager_mock.go 0.00% 8 Missing ⚠️
...uler/resource/persistentcache/task_manager_mock.go 0.00% 4 Missing ⚠️
scheduler/resource/persistentcache/resource.go 0.00% 2 Missing ⚠️
scheduler/service/service_v2.go 0.00% 1 Missing ⚠️
Additional details and impacted files

Impacted file tree graph

@@            Coverage Diff             @@
##             main    #3619      +/-   ##
==========================================
- Coverage   35.67%   35.57%   -0.11%     
==========================================
  Files         335      335              
  Lines       37294    37389      +95     
==========================================
- Hits        13305    13301       -4     
- Misses      23146    23244      +98     
- Partials      843      844       +1     
Flag Coverage Δ
unittests 35.57% <0.00%> (-0.11%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

Files with missing lines Coverage Δ
client/config/mocks/dynconfig_mock.go 3.30% <ø> (ø)
client/daemon/announcer/mocks/announcer_mock.go 0.00% <ø> (ø)
...t/daemon/objectstorage/mocks/objectstorage_mock.go 0.00% <ø> (ø)
client/daemon/peer/peertask_manager_mock.go 38.18% <ø> (ø)
client/daemon/peer/piece_downloader_mock.go 100.00% <ø> (ø)
client/daemon/peer/piece_manager_mock.go 0.00% <ø> (ø)
client/daemon/proxy/mocks/proxy_manager_mock.go 0.00% <ø> (ø)
client/daemon/rpcserver/mocks/rpcserver_mock.go 0.00% <ø> (ø)
...lient/daemon/storage/mocks/stroage_manager_mock.go 32.65% <ø> (ø)
client/daemon/upload/mocks/upload_manager_mock.go 0.00% <ø> (ø)
... and 53 more

@gaius-qi gaius-qi force-pushed the feature/delete-persistent-cache-task branch from 5c31a04 to 3e4dcc0 Compare October 29, 2024 13:29
Copy link
Member

@chlins chlins left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@gaius-qi gaius-qi merged commit 58959be into main Oct 29, 2024
27 checks passed
@gaius-qi gaius-qi deleted the feature/delete-persistent-cache-task branch October 29, 2024 14:24
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants