Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: add filtered query params of the containerd #3621

Merged
merged 1 commit into from
Oct 30, 2024
Merged

Conversation

gaius-qi
Copy link
Member

@gaius-qi gaius-qi commented Oct 30, 2024

Description

This pull request includes changes to the pkg/net/http/header.go file to enhance the handling of query parameters for generating task IDs. The most important changes include adding a new set of filtered query parameters for containerd and updating the default filtered query parameters to include these new parameters.

Enhancements to query parameter handling:

  • pkg/net/http/header.go: Added ContainerdQueryParams to handle containerd specific query parameters. ([pkg/net/http/header.goR77-R83](https://github.com/dragonflyoss/dragonfly/pull/3621/files#diff-0ae93eed228c1b5586b56da501ed24f84ef016f038402cd4f42f1a6b45ce20f1R77-R83))
  • pkg/net/http/header.go: Updated DefaultFilteredQueryParams to include ContainerdQueryParams for generating task IDs. ([pkg/net/http/header.goR77-R83](https://github.com/dragonflyoss/dragonfly/pull/3621/files#diff-0ae93eed228c1b5586b56da501ed24f84ef016f038402cd4f42f1a6b45ce20f1R77-R83))

Related Issue

Motivation and Context

Screenshots (if appropriate)

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)
  • Documentation Update (if none of the other choices apply)

Checklist

  • My change requires a change to the documentation.
  • I have updated the documentation accordingly.
  • I have read the CONTRIBUTING document.
  • I have added tests to cover my changes.

@gaius-qi gaius-qi added the enhancement New feature or request label Oct 30, 2024
@gaius-qi gaius-qi added this to the v2.2.0 milestone Oct 30, 2024
@gaius-qi gaius-qi self-assigned this Oct 30, 2024
@gaius-qi gaius-qi requested a review from a team as a code owner October 30, 2024 06:02
Copy link
Member

@chlins chlins left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

Copy link
Member

@fcgxz2003 fcgxz2003 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@gaius-qi gaius-qi merged commit 19b38a1 into main Oct 30, 2024
24 checks passed
@gaius-qi gaius-qi deleted the feature/containerd branch October 30, 2024 06:14
Copy link

codecov bot commented Oct 30, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 35.59%. Comparing base (58959be) to head (e0abe56).
Report is 1 commits behind head on main.

Additional details and impacted files

Impacted file tree graph

@@            Coverage Diff             @@
##             main    #3621      +/-   ##
==========================================
- Coverage   35.60%   35.59%   -0.01%     
==========================================
  Files         335      335              
  Lines       37389    37389              
==========================================
- Hits        13311    13308       -3     
- Misses      23237    23240       +3     
  Partials      841      841              
Flag Coverage Δ
unittests 35.59% <ø> (-0.01%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

see 1 file with indirect coverage changes

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants