Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: generate wrong sql with gorm #3626

Merged
merged 1 commit into from
Oct 31, 2024
Merged

fix: generate wrong sql with gorm #3626

merged 1 commit into from
Oct 31, 2024

Conversation

gaius-qi
Copy link
Member

@gaius-qi gaius-qi commented Oct 31, 2024

Description

This pull request includes updates to the dependencies in the go.mod file, specifically downgrading some of the versions for MySQL and GORM-related packages.

Dependency version changes:

  • go.mod: Downgraded github.com/go-sql-driver/mysql from v1.7.1 to v1.7.0.
  • go.mod: Downgraded gorm.io/driver/mysql from v1.5.4 to v1.4.7.
  • go.mod: Downgraded gorm.io/driver/postgres from v1.5.7 to v1.4.8.
  • go.mod: Downgraded gorm.io/gorm from v1.25.10 to v1.24.6.

Related Issue

Motivation and Context

Fixed #3581 #3624 #3625

Screenshots (if appropriate)

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)
  • Documentation Update (if none of the other choices apply)

Checklist

  • My change requires a change to the documentation.
  • I have updated the documentation accordingly.
  • I have read the CONTRIBUTING document.
  • I have added tests to cover my changes.

@gaius-qi gaius-qi added the enhancement New feature or request label Oct 31, 2024
@gaius-qi gaius-qi added this to the v2.2.0 milestone Oct 31, 2024
@gaius-qi gaius-qi self-assigned this Oct 31, 2024
@gaius-qi gaius-qi requested a review from a team as a code owner October 31, 2024 13:47
Copy link
Member

@fcgxz2003 fcgxz2003 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Copy link

codecov bot commented Oct 31, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 35.41%. Comparing base (e826d72) to head (6716494).
Report is 1 commits behind head on main.

Additional details and impacted files

Impacted file tree graph

@@            Coverage Diff             @@
##             main    #3626      +/-   ##
==========================================
- Coverage   35.42%   35.41%   -0.02%     
==========================================
  Files         335      335              
  Lines       37572    37572              
==========================================
- Hits        13311    13306       -5     
- Misses      23420    23423       +3     
- Partials      841      843       +2     
Flag Coverage Δ
unittests 35.41% <ø> (-0.02%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

see 3 files with indirect coverage changes

@gaius-qi gaius-qi merged commit da8eab8 into main Oct 31, 2024
27 checks passed
@gaius-qi gaius-qi deleted the feature/postgre branch October 31, 2024 14:15
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Error connecting to PostgreSQL database
3 participants