Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: optimize api for shceduling #3660

Merged
merged 1 commit into from
Nov 22, 2024
Merged

feat: optimize api for shceduling #3660

merged 1 commit into from
Nov 22, 2024

Conversation

gaius-qi
Copy link
Member

Description

This pull request includes several changes to improve the handling of time fields and update dependencies. The most important changes involve converting integer parsing functions to their unsigned counterparts and updating the d7y.io/api/v2 module version.

Dependency update:

  • go.mod: Updated d7y.io/api/v2 module version from v2.0.171 to v2.0.173.

Time field parsing improvements:

Related Issue

Motivation and Context

Screenshots (if appropriate)

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)
  • Documentation Update (if none of the other choices apply)

Checklist

  • My change requires a change to the documentation.
  • I have updated the documentation accordingly.
  • I have read the CONTRIBUTING document.
  • I have added tests to cover my changes.

@gaius-qi gaius-qi added the enhancement New feature or request label Nov 22, 2024
@gaius-qi gaius-qi added this to the v2.2.0 milestone Nov 22, 2024
@gaius-qi gaius-qi self-assigned this Nov 22, 2024
@gaius-qi gaius-qi requested a review from a team as a code owner November 22, 2024 12:39
Copy link

codecov bot commented Nov 22, 2024

Codecov Report

Attention: Patch coverage is 0% with 3 lines in your changes missing coverage. Please review.

Project coverage is 35.42%. Comparing base (c05bff9) to head (6dfa39e).
Report is 1 commits behind head on main.

Files with missing lines Patch % Lines
scheduler/resource/persistentcache/host_manager.go 0.00% 1 Missing ⚠️
scheduler/resource/persistentcache/peer_manager.go 0.00% 1 Missing ⚠️
scheduler/resource/persistentcache/task_manager.go 0.00% 1 Missing ⚠️
Additional details and impacted files

Impacted file tree graph

@@           Coverage Diff           @@
##             main    #3660   +/-   ##
=======================================
  Coverage   35.42%   35.42%           
=======================================
  Files         335      335           
  Lines       37531    37531           
=======================================
  Hits        13296    13296           
  Misses      23406    23406           
  Partials      829      829           
Flag Coverage Δ
unittests 35.42% <0.00%> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

Files with missing lines Coverage Δ
scheduler/resource/persistentcache/host_manager.go 0.00% <0.00%> (ø)
scheduler/resource/persistentcache/peer_manager.go 0.00% <0.00%> (ø)
scheduler/resource/persistentcache/task_manager.go 0.00% <0.00%> (ø)
---- 🚨 Try these New Features:

@gaius-qi gaius-qi merged commit 9376c5d into main Nov 22, 2024
27 checks passed
@gaius-qi gaius-qi deleted the feature/api branch November 22, 2024 12:58
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant