Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update typo in local_storage.go #955

Merged
merged 2 commits into from
Jan 13, 2022
Merged

Update typo in local_storage.go #955

merged 2 commits into from
Jan 13, 2022

Conversation

guoguodan
Copy link
Contributor

UPDATE: seked-->sought

UPDATE: seked-->sought
@guoguodan guoguodan requested a review from a team as a code owner December 24, 2021 01:37
UPDATE:seeked-->sought
@codecov-commenter
Copy link

codecov-commenter commented Dec 24, 2021

Codecov Report

Merging #955 (0cfcf26) into main (03600f3) will decrease coverage by 0.30%.
The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff             @@
##             main     #955      +/-   ##
==========================================
- Coverage   42.86%   42.56%   -0.31%     
==========================================
  Files         115      116       +1     
  Lines        8639     8761     +122     
==========================================
+ Hits         3703     3729      +26     
- Misses       4466     4571     +105     
+ Partials      470      461       -9     
Flag Coverage Δ
Object-compatibility-e2etests ?
e2etests ?
unittests 42.56% <ø> (-0.31%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
client/daemon/storage/local_storage.go 25.09% <ø> (-0.39%) ⬇️
client/daemon/storage/storage_manager.go 19.34% <ø> (-1.43%) ⬇️
client/config/dfget.go 20.77% <0.00%> (-2.76%) ⬇️
client/dfget/dfget.go 13.63% <0.00%> (-2.12%) ⬇️
client/daemon/peer/peertask_stream.go 55.45% <0.00%> (-0.32%) ⬇️
cdn/supervisor/cdn/storage/disk/disk.go 14.18% <0.00%> (-0.31%) ⬇️
cdn/supervisor/task/manager.go 26.47% <0.00%> (-0.27%) ⬇️
pkg/source/source_client.go 1.85% <0.00%> (-0.04%) ⬇️
... and 11 more

Copy link
Member

@jim3ma jim3ma left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@jim3ma
Copy link
Member

jim3ma commented Dec 24, 2021

Please sign off your commit by "git commit --amend -s" and force push again.

jim3ma
jim3ma previously requested changes Dec 24, 2021
Copy link
Member

@jim3ma jim3ma left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@jim3ma jim3ma changed the title Update local_storage.go Update typo in local_storage.go Dec 24, 2021
Copy link
Member

@gaius-qi gaius-qi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please sign off next time.

@gaius-qi gaius-qi dismissed jim3ma’s stale review January 13, 2022 13:20

Sign off next time.

@gaius-qi gaius-qi merged commit 286f126 into dragonflyoss:main Jan 13, 2022
gaius-qi pushed a commit that referenced this pull request Jun 28, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants