Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: add scheduler host GC #989

Merged
merged 1 commit into from
Jan 13, 2022
Merged

feat: add scheduler host GC #989

merged 1 commit into from
Jan 13, 2022

Conversation

gaius-qi
Copy link
Member

Signed-off-by: Gaius [email protected]

Description

  • Add scheduler host GC.

Related Issue

Motivation and Context

Screenshots (if appropriate):

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)
  • Documentation Update (if none of the other choices apply)

Checklist:

  • Code compiles correctly.
  • My code follows the code style of this project.
  • My change requires a change to the documentation.
  • I have updated the documentation accordingly.
  • I have read the CONTRIBUTING document.
  • I have added tests to cover my changes.
  • All new and existing tests passed.

@gaius-qi gaius-qi added this to the v2.0.2 milestone Jan 13, 2022
@gaius-qi gaius-qi self-assigned this Jan 13, 2022
@gaius-qi gaius-qi requested a review from a team as a code owner January 13, 2022 03:53
@codecov-commenter
Copy link

codecov-commenter commented Jan 13, 2022

Codecov Report

Merging #989 (699235d) into main (ed14688) will increase coverage by 0.05%.
The diff coverage is 73.33%.

Impacted file tree graph

@@            Coverage Diff             @@
##             main     #989      +/-   ##
==========================================
+ Coverage   45.65%   45.71%   +0.05%     
==========================================
  Files         129      129              
  Lines        9002     9057      +55     
==========================================
+ Hits         4110     4140      +30     
- Misses       4427     4458      +31     
+ Partials      465      459       -6     
Flag Coverage Δ
Object-compatibility-e2etests ?
e2etests ?
unittests 45.71% <73.33%> (+0.05%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
scheduler/config/config.go 0.00% <0.00%> (ø)
scheduler/resource/host_manager_mock.go 25.00% <0.00%> (-5.77%) ⬇️
scheduler/resource/host_manager.go 100.00% <100.00%> (ø)
scheduler/resource/resource.go 81.81% <100.00%> (+1.81%) ⬆️
client/daemon/peer/piece_downloader.go 56.86% <0.00%> (-12.19%) ⬇️
client/daemon/peer/peertask_conductor.go 52.85% <0.00%> (-0.28%) ⬇️
pkg/sync/krwmutex.go 86.36% <0.00%> (+4.54%) ⬆️
pkg/sync/kmutex.go 100.00% <0.00%> (+16.66%) ⬆️

Copy link
Member

@jim3ma jim3ma left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@gaius-qi gaius-qi merged commit 82e2294 into main Jan 13, 2022
@gaius-qi gaius-qi deleted the feature/host-gc branch January 13, 2022 13:34
gaius-qi added a commit that referenced this pull request Jun 28, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants