-
Notifications
You must be signed in to change notification settings - Fork 212
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add some unit test for utils, storage, rafs, api and builder. #1475
Conversation
Signed-off-by: weizhen.zt <[email protected]>
Signed-off-by: weizhen.zt <[email protected]>
Signed-off-by: weizhen.zt <[email protected]>
Signed-off-by: weizhen.zt <[email protected]>
Signed-off-by: weizhen.zt <[email protected]>
Codecov Report
@@ Coverage Diff @@
## master #1475 +/- ##
==========================================
+ Coverage 54.86% 62.49% +7.63%
==========================================
Files 123 123
Lines 40477 43132 +2655
Branches 40477 43132 +2655
==========================================
+ Hits 22208 26956 +4748
+ Misses 17033 14868 -2165
- Partials 1236 1308 +72
|
Great work, thanks! @ZouTaooo |
@ZouTaooo Thanks for your contribution! It looks really good. |
storage/Cargo.toml
Outdated
@@ -35,6 +35,7 @@ url = { version = "2.1.1", optional = true } | |||
vm-memory = "0.10" | |||
fuse-backend-rs = "^0.10.3" | |||
gpt = { version = "3.0.0", optional = true } | |||
toml = "0.5" |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Maybe move it to [dev-dependencies]
.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for your review. Now, I have fixed it with new commit.
Signed-off-by: weizhen.zt <[email protected]>
Signed-off-by: weizhen.zt <[email protected]>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The Smoke-Test found a test-case error. And the commit fix it.
Two seconds is an edge-case, but there is a resolution problem in linux timer. So the data will be updated with different index sometimes. So the new test case with two changes, first using the normal argument rather than edge case, secondly considering the timer delta error.
Relevant Issue (if applicable)
If there are Issues related to this PullRequest, please list it.
Details
Please describe the details of PullRequest.
Types of changes
What types of changes does your PullRequest introduce? Put an
x
in all the boxes that apply:Checklist
Go over all the following points, and put an
x
in all the boxes that apply.