Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix Duplicate files copied in APK META-INF/library_release.kotlin_module #284

Merged
merged 1 commit into from
Sep 7, 2019
Merged

Fix Duplicate files copied in APK META-INF/library_release.kotlin_module #284

merged 1 commit into from
Sep 7, 2019

Conversation

litangyu
Copy link
Contributor

@litangyu litangyu commented Aug 1, 2019

@drakeet
Copy link
Owner

drakeet commented Aug 26, 2019

Thank you for your feedback and PR, but I can not reproduce it and verify it. I am not sure why we need this. In addition, the -module-name seems to require a complete groupId but you just set a multitype without its full groupId.

@drakeet drakeet merged commit f3ac96f into drakeet:master Sep 7, 2019
@drakeet
Copy link
Owner

drakeet commented Sep 7, 2019

I realize we don't need to set a full path with group id, just multitype is good enough. Thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@litangyu @drakeet