DX-67209 updated aes_encrypt/decrypt #29
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Thanks for opening a pull request! If this is not a minor PR. Could you open an issue for this pull request on GitHub? https://github.com/apache/arrow/issues/new/choose Opening GitHub issues ahead of time contributes to the Openness of the Apache Arrow project. Then could you also rename the pull request title in the following format? or In the case of PARQUET issues on JIRA the title also supports: See also: |
github-actions
bot
added
Component: C++
Component: C++ - Gandiva
awaiting review
labels
lriggs
reviewed
Jul 7, 2023
cpp/src/gandiva/encrypt_utils.cc
Outdated
|
|
||
| if (!en_ctx) { | ||
| throw std::runtime_error("could not create a new evp cipher ctx for encryption"); | ||
| } | ||
|
|
||
| if (!EVP_EncryptInit_ex(en_ctx, EVP_aes_128_ecb(), nullptr, | ||
| switch (key_len) { |
There was a problem hiding this comment.
This could be combined with the other similar code below into a helper function.
Comment on lines
+320
to
+325
| if (key_data_len == 16 || key_data_len == 24 || key_data_len == 32) { | ||
| kAesBlockSize = static_cast<int64_t>(key_data_len); | ||
| } else { | ||
| gdv_fn_context_set_error_msg(context, "invalid key length"); | ||
| *out_len = 0; | ||
| return nullptr; |
There was a problem hiding this comment.
Don't the helper functions already check the length? I think it would be better to just do the check in one place since the code would be easier to read and better tested. It doesn't look like this path is being tested since the unit tests call the helper functions.
lriggs
approved these changes
Jul 13, 2023
lriggs
pushed a commit
that referenced
this pull request
Jul 13, 2023
* DX-67209 updated aes_encrypt/decrypt
lriggs
pushed a commit
that referenced
this pull request
Jul 21, 2023
* DX-67209 updated aes_encrypt/decrypt
lriggs
pushed a commit
that referenced
this pull request
Jul 28, 2023
* DX-67209 updated aes_encrypt/decrypt
xxlaykxx
added a commit
that referenced
this pull request
Oct 29, 2023
* DX-67209 updated aes_encrypt/decrypt
DenisTarasyuk
pushed a commit
that referenced
this pull request
Dec 19, 2023
* DX-67209 updated aes_encrypt/decrypt
DenisTarasyuk
pushed a commit
that referenced
this pull request
Jan 16, 2024
* DX-67209 updated aes_encrypt/decrypt
DenisTarasyuk
pushed a commit
that referenced
this pull request
Mar 6, 2024
* DX-67209 updated aes_encrypt/decrypt
lriggs
pushed a commit
to lriggs/arrow
that referenced
this pull request
Mar 12, 2024
* DX-67209 updated aes_encrypt/decrypt
lriggs
pushed a commit
to lriggs/arrow
that referenced
this pull request
Apr 25, 2024
* DX-67209 updated aes_encrypt/decrypt
stevelorddremio
pushed a commit
to stevelorddremio/arrow
that referenced
this pull request
Jun 14, 2024
* DX-67209 updated aes_encrypt/decrypt
lriggs
pushed a commit
to lriggs/arrow
that referenced
this pull request
Sep 3, 2024
* DX-67209 updated aes_encrypt/decrypt
lriggs
pushed a commit
to lriggs/arrow
that referenced
this pull request
Sep 6, 2024
* DX-67209 updated aes_encrypt/decrypt
lriggs
pushed a commit
to lriggs/arrow
that referenced
this pull request
Dec 9, 2024
* DX-67209 updated aes_encrypt/decrypt
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
aes_ecrypt/decrypt support 128, 192, 254 bit key and this strict requirement - key should be 16 or 24 or 32 chars.
If not - error will be returned.