Add devcontainers support to the repository #267
Conversation
|
This PR is mostly based on https://github.com/vandop/dremio-personal-analytics/ with some minor changes. We could think about kicking out Apache superset since most developers are probably not going to need it. There should also be an easy way to replace the oss dremio container with a self-hosted enterprise version if we're working on an enterprise-only feature. |
simonpannek
force-pushed
the
dbt-dremio-dev-containers
branch
from
fdbcaae to
205f53b
Compare
| - dremio-laptop-lakehouse | ||
| volumes: | ||
| - dremio_data:/opt/dremio/data:rw | ||
| user: "0" |
There was a problem hiding this comment.
I mean, as long as we don't find another workaround for this work in podman, I assume we should leave it in...
There was a problem hiding this comment.
@simonpannek let's add a comment why are we doing it at least?
There was a problem hiding this comment.
Great PR! I've compared with https://github.com/vandop/dremio-personal-analytics/ and saw the changes you made, they make sense to me
| @@ -0,0 +1,105 @@ | |||
| services: | |||
There was a problem hiding this comment.
Could we create a folder in the repo and move all the sh and yml files there?
Or in leave them in .devcontainer folder?
There was a problem hiding this comment.
The docker-compose and setup files can be used, even if you're not using devcontainers, but I'm fine moving them into a separate folder as well. I think in that cast, I'd leave them in .devcontainer
| "workspaceFolder": "/usr/src/app", | ||
|
|
||
| "runArgs": [ | ||
| "--userns=keep-id:uid=1000,gid=1000" |
There was a problem hiding this comment.
Why do we need these arguments and for what service they are?
| - dremio-laptop-lakehouse | ||
| volumes: | ||
| - dremio_data:/opt/dremio/data:rw | ||
| user: "0" |
There was a problem hiding this comment.
@simonpannek let's add a comment why are we doing it at least?
Description
This PR aims to introduce devcontainer support to this repository. With this addition, developers will be able to quickly set up and run a dockerized environment in VSCode, GitHub Codespaces, or any other platform that supports devcontainers.
Test Results
TODO
Changelog