-
Notifications
You must be signed in to change notification settings - Fork 506
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Removal of legacy code for various devices #7822
Conversation
Thanks, always nice to see the C++ monsters shrinking :) I'd suggest we merge this in the first v2.28.0-beta since this is mostly a cleanup. For the "Sinope TH1123ZB/TH1124ZB thermostats" when I read it right this brings the TH1123ZB from legacy code into the DDF with a few enhancements. Here I'd prefer to have this bit as separate PR. |
Yeah, still a long way to go to get the old stuff out
I guess this looks more serious than it actually is. If memory serves, the 2 devices are identical except for the load they can manage. In that sense, just added the 1123 to the DDF, added the bindings on the thermostat cluster that were missing (incl. refresh amendments) and corrected the non-functioning However, if you still prefer a seperate PR for it, I can set one up. |
Ah ok thanks, keeping it as one PR here is fine by me. |
Also needs a small update to make GIT happy :) |
Then let Git be happy 🙂 |
This pull request is now merged. The new DDB files have been uploaded to the store. DDB FilesModified
🕗 Updated for commit e97d5be |
Devices are meanwhile covered by DDFs: