Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Removal of legacy code for various devices #7822

Merged
merged 5 commits into from
Aug 9, 2024

Conversation

SwoopX
Copy link
Collaborator

@SwoopX SwoopX commented Jun 25, 2024

Devices are meanwhile covered by DDFs:

  • Wiser iTRV thermostat
  • Ikea Styrbar remote
  • Ikea Kadrilj blind
  • Sinope TH1123ZB/TH1124ZB thermostats

Copy link
Contributor

github-actions bot commented Jun 25, 2024

Hey @SwoopX, thanks for your pull request!

Tip

Modified bundles can be downloaded here.
Relative expire date

DDB changes

Modified

  • sinope/th1124zb.json : Smart thermostat for electric heating (TH1123ZB/TH1124ZB) ✔️

Validation

Tip

Everything is fine !

🕔 Updated for commit 7bc41e9

@manup
Copy link
Member

manup commented Jun 28, 2024

Thanks, always nice to see the C++ monsters shrinking :)

I'd suggest we merge this in the first v2.28.0-beta since this is mostly a cleanup.

For the "Sinope TH1123ZB/TH1124ZB thermostats" when I read it right this brings the TH1123ZB from legacy code into the DDF with a few enhancements. Here I'd prefer to have this bit as separate PR.

@SwoopX
Copy link
Collaborator Author

SwoopX commented Jun 28, 2024

Yeah, still a long way to go to get the old stuff out

For the "Sinope TH1123ZB/TH1124ZB thermostats" when I read it right this brings the TH1123ZB from legacy code into the DDF with a few enhancements. Here I'd prefer to have this bit as separate PR.

I guess this looks more serious than it actually is. If memory serves, the 2 devices are identical except for the load they can manage. In that sense, just added the 1123 to the DDF, added the bindings on the thermostat cluster that were missing (incl. refresh amendments) and corrected the non-functioning state/on.

However, if you still prefer a seperate PR for it, I can set one up.

@manup
Copy link
Member

manup commented Jul 10, 2024

Ah ok thanks, keeping it as one PR here is fine by me.
Added to v2.28.0-beta milestone.

@manup manup added this to the v2.28.0-beta milestone Jul 10, 2024
@manup
Copy link
Member

manup commented Aug 8, 2024

Also needs a small update to make GIT happy :)

@SwoopX
Copy link
Collaborator Author

SwoopX commented Aug 8, 2024

Then let Git be happy 🙂

@manup manup merged commit e97d5be into dresden-elektronik:master Aug 9, 2024
1 check passed
Copy link
Contributor

github-actions bot commented Aug 9, 2024

This pull request is now merged. The new DDB files have been uploaded to the store.

DDB Files

Modified

  • sinope/th1124zb.json : Smart thermostat for electric heating (TH1123ZB/TH1124ZB) : with hash (649b4fa640)

🕗 Updated for commit e97d5be

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants