-
Notifications
You must be signed in to change notification settings - Fork 506
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Removal of config/temperature
for various Xiaomi devices
#7827
Conversation
Hey @mattreim, thanks for your pull request! Tip Modified bundles can be downloaded here. DDB changesModified
ValidationTip Everything is fine ! 🕟 Updated for commit 19eb20f |
config/temperature
for various Xiaomi devices
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I like this; config/temperature
has been nothing but confusion. I think we should remove it from all Xiaomi devices and deprecate the resource item (I don't think it's used by other devices).
@@ -46,6 +46,19 @@ | |||
}, | |||
{ | |||
"name": "attr/swversion", | |||
"parse": { |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Isn't this already reported through the Xiaomi special attribute?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for the tip, I'll try it again.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
It seems to work.
@@ -138,6 +140,19 @@ | |||
}, | |||
{ | |||
"name": "attr/swversion", | |||
"parse": { |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Isn't this already reported through the Xiaomi special attribute?
…qq11lm_presence_sensor)
800aa56
to
49eea81
Compare
I definitively support this one as well. However, there's probably more devices out there where this should be done and then the universe will start yelling at us that we must bring this back. As I recall, none of the DDFs initially had that temperature crazyness included at the very beginning and not even Xiaomi is neither offering nor making any use of that value. |
Over time it turned out that the sensor didn't recognize the version after all. |
This pull request is now merged. The new DDB files have been uploaded to the store. DDB FilesModified
🕘 Updated for commit b497467 |
Quick note for myself for Xiaomi motion sensor (lumi.sensor_motion.aq2). Additionally the wiki description for the payload: https://github.com/dresden-elektronik/deconz-rest-plugin/wiki/Xiaomi-manufacturer-specific-clusters,-attributes-and-attribute-reporting#xiaomi-aqara-door-sensor--lumisensor_motionaq2 The special report for this sensor doesn't contain firmware version, so the conclusion to use the Basic Cluster attribute 0x0001 is correct in this PR. In my setup the sensor was still making troubles and didn't send special reports (needed for battery and reachable), only randomly it started to work after re-paring multiple times. Unsolved mystery ... |
Thanks for the information. |
No description provided.