Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Make state/alert customizable through DDF #7839

Merged
merged 3 commits into from
Aug 8, 2024

Conversation

SwoopX
Copy link
Collaborator

@SwoopX SwoopX commented Jul 13, 2024

Not all state resource items are fit for usage in DDFs yet. Especially with lights, they are often associated with commands and the functionality is hardcoded. To allow customization in DDFs, the item shall accept arbitrary commands for the values "select" and "none". The value "lselect" (to pass a user defined ontime via API) is currently skipped, as there's currently no aligned way to expose/leverage it. For the time being, this works via legacy code; so do the other possible values.

The changes have been tested with the Develco/frient smoke and heat sensors and the DDFs were updated accordingly.

Copy link
Contributor

github-actions bot commented Jul 13, 2024

Hey @SwoopX, thanks for your pull request!

Tip

Modified bundles can be downloaded here.
Relative expire date

DDB changes

Modified

  • develco/heszb-120_heat_detector.json : Intelligent heat alarm (HESZB-120) ✔️

  • frient/heszb-120_heat_detector.json : Intelligent heat alarm (HESZB-120) ✔️

  • develco/smszb-120_smoke_detector.json : Intelligent smoke alarm (SMSZB-120) ✔️

  • frient/smszb-120_smoke_detector.json : Intelligent smoke alarm (SMSZB-120) ✔️

Validation

Tip

Everything is fine !

🕗 Updated for commit 20ede2f

@SwoopX SwoopX marked this pull request as ready for review July 14, 2024 19:28
@SwoopX SwoopX added this to the v2.28.0-beta milestone Jul 14, 2024
@manup
Copy link
Member

manup commented Aug 7, 2024

Guess this needs a small refresh to solve merge conflict due earlier merged large PR :)

@manup manup merged commit bbff304 into dresden-elektronik:master Aug 8, 2024
1 check passed
Copy link
Contributor

github-actions bot commented Aug 8, 2024

This pull request is now merged. The new DDB files have been uploaded to the store.

DDB Files

Modified

  • develco/heszb-120_heat_detector.json : Intelligent heat alarm (HESZB-120) : with hash (1e2b4ef2d7)

  • frient/smszb-120_smoke_detector.json : Intelligent smoke alarm (SMSZB-120) : with hash (b0622b9aa5)

  • develco/smszb-120_smoke_detector.json : Intelligent smoke alarm (SMSZB-120) : with hash (2f5b51dfcc)

  • frient/heszb-120_heat_detector.json : Intelligent heat alarm (HESZB-120) : with hash (37ef5d6876)

🕣 Updated for commit bbff304

@SwoopX SwoopX deleted the updateForDDFsirens branch August 8, 2024 21:27
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants