-
Notifications
You must be signed in to change notification settings - Fork 506
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
DDF for Aqara Ceiling Light T1M (CL-L02D) #7895
Conversation
Aqara Ceiling Light T1M, see dresden-elektronik#7653.
Add non-public `state/x` and `state/y` to prevent the legacy code from kicking in. See dresden-elektronik#7653
Oh, this is fun.
Oops, I intended for |
Fix validator errors, see dresden-elektronik#7895.
- Adjust colour gamut to prevent ring from not dimming. - Add `parse` logic to `state` attributes to prevent REST API from mixing endpoints and resources.
Add bindings for _Color Control_ on 2nd endpoint.
Thanks, interesting corner cases for the device. |
Yes we can do that for initial support. We shouldn’t close the corresponding issue, however, since we still need to add support for the effects and gradients (after reverse-engineering these). I’m rather worried about the legacy code interfering with the DDF. I think with all non-public items, I’ve now bypassed most legacy logic, but I’m sure I caught all of it. Would be good to get feedback from others. |
There is the It can be enabled for a session via: GUI → Panels → Control → DDF mode → Strict But I think this needs a fresh look where |
This pull request is now merged. The new DDB files have been uploaded to the store. DDB FilesModified
🕜 Updated for commit 4b6435e |
See #7653.
Initial DDF, exposing both light endpoints: main light as Color Temperature Light and ring light as Extended Color Light. No support yet for dynamic effects, nor for gradients of the ring light.
Somehow, the ring won't dim at
xy
[0, 1] (red) or [0, 0] (blue). When mixing some other colour, like [0, 0.01] it will. Not sure what's happening here. Maybe we need to adjust the gamut slightly, to prevent [0, 0], and [0, 1]. At [1, 0] (green), it will dim.