Fix ResourceItems no longer processed when loading additional DDFs #8043
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Problem in the issue was reproduced by joining a device without DDF, existing devices stopped processing some of the resource items. The main issue was that when loading new DDFs during a session the load counter got updated for all items in all DDFs, but the device items in memory still pointed to former load counter. TLTR the load counter should only be incremented for the actually new DDF which is loaded into memory. dresden-elektronik#7935
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Problem in the issue was reproduced by joining a device without DDF, existing devices stopped processing some of the resource items. The main issue was that when loading new DDFs during a session the per item load counter got updated for all items in all DDFs, but the device items in memory still pointed to former load counter.
TLTR the load counter should only be incremented for the actually new DDF which is loaded into memory.
Fixes: #7935