Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[#77] Improved logger. #81

Merged
merged 37 commits into from
Mar 29, 2024
Merged

[#77] Improved logger. #81

merged 37 commits into from
Mar 29, 2024

Conversation

tannguyen04
Copy link
Contributor

@tannguyen04 tannguyen04 commented Mar 19, 2024

Checklist before requesting a review

closes #77

  • I have formatted the subject to include ticket number as [#123] Verb in past tense with dot at the end.
  • I have added a link to the issue tracker
  • I have provided information in Changed section about WHY something was done if this was not a normal implementation
  • I have performed a self-review of my code
  • I have commented my code, particularly in hard-to-understand areas
  • I have added tests that prove my fix is effective or that my feature works
  • I have run new and existing relevant tests locally with my changes, and they passed
  • I have provided screenshots, where applicable

Changed

Screenshots

@codecov-commenter
Copy link

codecov-commenter commented Mar 29, 2024

Codecov Report

Attention: Patch coverage is 1.63934% with 60 lines in your changes are missing coverage. Please review.

Project coverage is 31.38%. Comparing base (22c667c) to head (645cce2).

Files Patch % Lines
src/Commands/ArtifactCommand.php 2.38% 41 Missing ⚠️
src/LogTrait.php 0.00% 19 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main      #81      +/-   ##
==========================================
- Coverage   32.21%   31.38%   -0.83%     
==========================================
  Files           6        7       +1     
  Lines         537      548      +11     
==========================================
- Hits          173      172       -1     
- Misses        364      376      +12     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@tannguyen04 tannguyen04 marked this pull request as ready for review March 29, 2024 02:51
@tannguyen04 tannguyen04 changed the title [#77] Improve logger. [#77] Improved logger. Mar 29, 2024
@AlexSkrypnyk AlexSkrypnyk merged commit fb3d760 into main Mar 29, 2024
9 checks passed
@AlexSkrypnyk AlexSkrypnyk deleted the feature/improve-logger branch March 29, 2024 02:57
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Improve logger to allow logging into multiple channels
3 participants