Merge pull request MarlinFirmware#4342 from gudnimg/optimsation_timer…

…_class optimisation: Timer constructor can be `constexpr`
drewmoseley · Sep 13, 2023 · f5d48cd · f5d48cd
2 parents 9781e15 + a89e06a
commit f5d48cd
Show file tree

Hide file tree

Showing 2 changed files with 4 additions and 12 deletions.
diff --git a/Firmware/Timer.cpp b/Firmware/Timer.cpp
@@ -6,17 +6,6 @@
 #include "Timer.h"
 #include "system_timer.h"
 
-/**
- * @brief construct Timer
- *
- * It is guaranteed, that construction is equivalent with zeroing all members.
- * This property can be exploited in menu_data.
- */
-template<typename T>
-Timer<T>::Timer() : m_isRunning(false), m_started()
-{
-}
-
 /**
  * @brief Start timer
  */

diff --git a/Firmware/Timer.h b/Firmware/Timer.h
@@ -17,7 +17,10 @@ template <class T>
 class Timer
 {
 public:
-    Timer();
+    inline constexpr Timer()
+    : m_isRunning(false)
+    , m_started(0) {};
+
     void start();
     void stop(){m_isRunning = false;}
     bool running()const {return m_isRunning;}