Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix/pubsub client #82

Merged
merged 9 commits into from
Jan 31, 2025
Merged

Fix/pubsub client #82

merged 9 commits into from
Jan 31, 2025

Conversation

jordy25519
Copy link
Collaborator

@jordy25519 jordy25519 commented Dec 2, 2024 •
edited
Loading

Changes

  • classes with WebSockets now receive an Arc<PubsubClient> to better share the underlying resource
  • drift-rs bundles a patched PubsubClient with proper re/disconnection handling. It will panic on successive reconnection failures. Consumers should set panic = "abort"
  • the pubsub client transparently handles resubscriptions on reconnect

Fixes

  • Fixes multiple silent failure conditions with Ws connections

closes #80

@jordy25519 jordy25519 force-pushed the main branch 2 times, most recently from 5ed441f to 7e16c98 Compare January 7, 2025 03:24
@jordy25519 jordy25519 merged commit 0461f06 into main Jan 31, 2025
1 check passed
@jordy25519 jordy25519 deleted the fix/pubsub-client branch January 31, 2025 06:32
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Fix PubsubClient
1 participant
@jordy25519