Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use strategy instead of plugins for DDP #187

Merged
merged 8 commits into from
Jun 1, 2022
Merged

Use strategy instead of plugins for DDP #187

merged 8 commits into from
Jun 1, 2022

Conversation

ejm714
Copy link
Collaborator

@ejm714 ejm714 commented May 31, 2022

Changes:

  • properly sets up DDP
LightningDeprecationWarning: Passing <pytorch_lightning.plugins.training_type.ddp.DDPPlugin object at 0x7f9b62e37cd0> `strategy` to the `plugins` flag in Trainer has been deprecated in v1.5 and will be removed in v1.7. Use `Trainer(strategy=<pytorch_lightning.plugins.training_type.ddp.DDPPlugin object at 0x7f9b62e37cd0>)` instead.

For context, see PTL PR #12696

Bonus fixes:

  • add python extra for mkdocstrings
  • typo fixes
  • pin protocol buffer version to make tensorboard logger work

@ejm714 ejm714 changed the title Use strategy instead of accelerator Use strategy instead of plugins for DDP Jun 1, 2022
@github-actions
Copy link
Contributor

github-actions bot commented Jun 1, 2022

@@ -31,6 +31,7 @@ install_requires =
openpyxl
pandas>1.2.0
pandas_path
protobuf==3.20.1
Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

For context, see this github action error and protocol buffers update

@ejm714 ejm714 requested a review from pjbull June 1, 2022 01:00
@codecov-commenter
Copy link

codecov-commenter commented Jun 1, 2022

Codecov Report

Merging #187 (e397a12) into master (957f936) will not change coverage.
The diff coverage is n/a.

@@          Coverage Diff           @@
##           master    #187   +/-   ##
======================================
  Coverage    85.2%   85.2%           
======================================
  Files          30      30           
  Lines        1854    1854           
======================================
  Hits         1581    1581           
  Misses        273     273           
Impacted Files Coverage Δ
zamba/models/config.py 97.1% <ø> (ø)
zamba/models/model_manager.py 84.1% <ø> (ø)

@pjbull pjbull merged commit 7986c41 into master Jun 1, 2022
@pjbull pjbull deleted the ddp-update branch June 1, 2022 01:35
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants