Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix bug in download_weights #194

Merged
merged 3 commits into from
Jun 17, 2022
Merged

Fix bug in download_weights #194

merged 3 commits into from
Jun 17, 2022

Conversation

ejm714
Copy link
Collaborator

@ejm714 ejm714 commented Jun 17, 2022

Fix parenthesis so destination_dir is a PosixPath

Bonus fix:

  • removes ceiling for protobuf since this is handled by the latest tensorboard release

@github-actions
Copy link
Contributor

github-actions bot commented Jun 17, 2022

@codecov-commenter
Copy link

codecov-commenter commented Jun 17, 2022

Codecov Report

Merging #194 (8fe5374) into master (c2c7a94) will not change coverage.
The diff coverage is 100.0%.

❗ Current head 8fe5374 differs from pull request most recent head e455d28. Consider uploading reports for the commit e455d28 to get more accurate results

@@          Coverage Diff           @@
##           master    #194   +/-   ##
======================================
  Coverage    85.3%   85.3%           
======================================
  Files          30      30           
  Lines        1858    1858           
======================================
  Hits         1585    1585           
  Misses        273     273           
Impacted Files Coverage Δ
zamba/models/utils.py 100.0% <100.0%> (ø)

@ejm714 ejm714 merged commit a3b27ea into master Jun 17, 2022
@ejm714 ejm714 deleted the fix-download-weights branch June 17, 2022 21:23
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants