Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Release time distributed model trained with new frame selection #199

Merged
merged 8 commits into from
Jul 15, 2022

Conversation

ejm714
Copy link
Collaborator

@ejm714 ejm714 commented Jul 15, 2022

This PR updates the official time distributed model to one trained on the same dataset but using the new frame selection model (from #195).

This was essentially a one line change of updating the directory for time_distributed in the WEIGHT_LOOKUP dictionary. All the updates to the files in the official_models directory happen automatically as part of the make publish_models command. 🎉

Bonus fixes and adds:

  • updates the s3 directories of the other two models since we shuffled some things around in the s3 bucket
  • adds instructions markdown file for updating a model

Closes https://github.com/drivendataorg/pjmf-zamba/issues/96

@ejm714 ejm714 requested a review from pjbull July 15, 2022 19:12
@netlify
Copy link

netlify bot commented Jul 15, 2022

Deploy Preview for silly-keller-664934 ready!

Name Link
🔨 Latest commit 571d795
🔍 Latest deploy log https://app.netlify.com/sites/silly-keller-664934/deploys/62d1e392cd1eb90008cc0171
😎 Deploy Preview https://deploy-preview-199--silly-keller-664934.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site settings.

@github-actions
Copy link
Contributor

github-actions bot commented Jul 15, 2022

Copy link
Member

@pjbull pjbull left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Typo and a couple little things for the docs!

MAINTAINING.md Outdated Show resolved Hide resolved
MAINTAINING.md Outdated Show resolved Hide resolved
@ejm714
Copy link
Collaborator Author

ejm714 commented Jul 15, 2022

Comments integrated!

@ejm714 ejm714 requested a review from pjbull July 15, 2022 22:03
@codecov-commenter
Copy link

Codecov Report

Merging #199 (571d795) into master (57461a6) will decrease coverage by 0.0%.
The diff coverage is 0.0%.

@@           Coverage Diff            @@
##           master    #199     +/-   ##
========================================
- Coverage    86.9%   86.9%   -0.1%     
========================================
  Files          29      29             
  Lines        1901    1902      +1     
========================================
  Hits         1653    1653             
- Misses        248     249      +1     
Impacted Files Coverage Δ
zamba/models/config.py 97.1% <ø> (ø)
zamba/models/publish_models.py 0.0% <0.0%> (ø)

@pjbull pjbull merged commit 9557c88 into master Jul 15, 2022
@pjbull pjbull deleted the time-dist-new-frame-selection branch July 15, 2022 22:35
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants