-
Notifications
You must be signed in to change notification settings - Fork 27
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Release time distributed model trained with new frame selection #199
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
✅ Deploy Preview for silly-keller-664934 ready!
To edit notification comments on pull requests, go to your Netlify site settings. |
pjbull
requested changes
Jul 15, 2022
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Typo and a couple little things for the docs!
Comments integrated! |
Codecov Report
@@ Coverage Diff @@
## master #199 +/- ##
========================================
- Coverage 86.9% 86.9% -0.1%
========================================
Files 29 29
Lines 1901 1902 +1
========================================
Hits 1653 1653
- Misses 248 249 +1
|
pjbull
approved these changes
Jul 15, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR updates the official time distributed model to one trained on the same dataset but using the new frame selection model (from #195).
This was essentially a one line change of updating the directory for
time_distributed
in theWEIGHT_LOOKUP
dictionary. All the updates to the files in theofficial_models
directory happen automatically as part of themake publish_models
command. 🎉Bonus fixes and adds:
Closes https://github.com/drivendataorg/pjmf-zamba/issues/96