Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Release blank / nonblank model #228

Merged
merged 22 commits into from
Sep 23, 2022
Merged

Release blank / nonblank model #228

merged 22 commits into from
Sep 23, 2022

Conversation

ejm714
Copy link
Collaborator

@ejm714 ejm714 commented Sep 15, 2022

Adds a new official model: blank_nonblank. This was trained on both african forest and european data.

Additional changes:

  • lower cases labels in provided csv to improve matching with default model labels

Outstanding:

Closes https://github.com/drivendataorg/pjmf-zamba/issues/130

@netlify
Copy link

netlify bot commented Sep 15, 2022

Deploy Preview for silly-keller-664934 ready!

Name Link
🔨 Latest commit ad1e16c
🔍 Latest deploy log https://app.netlify.com/sites/silly-keller-664934/deploys/632cf094b6fbf60009762afc
😎 Deploy Preview https://deploy-preview-228--silly-keller-664934.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site settings.

@github-actions
Copy link
Contributor

github-actions bot commented Sep 15, 2022

@codecov-commenter
Copy link

codecov-commenter commented Sep 15, 2022

Codecov Report

Merging #228 (2229139) into master (2a4e9fc) will decrease coverage by 0.0%.
The diff coverage is 100.0%.

❗ Current head 2229139 differs from pull request most recent head ad1e16c. Consider uploading reports for the commit ad1e16c to get more accurate results

Additional details and impacted files
@@           Coverage Diff            @@
##           master    #228     +/-   ##
========================================
- Coverage    87.0%   87.0%   -0.1%     
========================================
  Files          29      28      -1     
  Lines        1937    1931      -6     
========================================
- Hits         1686    1680      -6     
  Misses        251     251             
Impacted Files Coverage Δ
zamba/models/config.py 96.7% <100.0%> (+<0.1%) ⬆️
zamba/__init__.py

@ejm714
Copy link
Collaborator Author

ejm714 commented Sep 16, 2022

@pjbull this is ready for review. You'll want to read through this issue as well which tries to capture the implications of releasing a binary model on our other configuration options.

@ejm714 ejm714 requested a review from pjbull September 19, 2022 22:09
Copy link
Member

@pjbull pjbull left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Let's update to remove "four" and just have plurals so we don't need to change the count of models in the future!

@@ -262,6 +302,8 @@ video_loader_config:
confidence: 0.25
fill_mode: score_sorted
n_frames: 32
image_height: 416
image_width: 416
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Update to new frame selection size (and maybe update default slowfast config?)

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This docs change brings the default in line with what is actually used. Whether what is used is desirable is another question.

The issue is that the official configs get generated from what was used for training, which in this case, was 416 x 416. If we change the default slowfast config manually, this will get overwritten the next time we publish models (since the official configs are generated from the full train configuration used for training, with the machine specific params removed). If we want to use slowfast with a different frame selection size, we'll need to change that workflow.

I'm not super inclined to fix this as part of this PR which just aims to release the BNB model. It's still an open question if we continue to support the slowfast model and if we retrain it on more data, which could make this point moot.

@ejm714
Copy link
Collaborator Author

ejm714 commented Sep 22, 2022

@pjbull I removed the number of models count and left a comment about the slowfast model (IMO nothing to do here, if we want different behavior, let's file an issue and do that separately). Ready for another look

@pjbull pjbull merged commit 291b34f into master Sep 23, 2022
@ejm714 ejm714 deleted the blank-non-blank branch September 26, 2022 21:19
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants