-
Notifications
You must be signed in to change notification settings - Fork 27
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add depth module #247
Add depth module #247
Conversation
✅ Deploy Preview for silly-keller-664934 ready!
To edit notification comments on pull requests, go to your Netlify site settings. |
Codecov Report
Additional details and impacted files@@ Coverage Diff @@
## master #247 +/- ##
========================================
+ Coverage 87.0% 87.6% +0.5%
========================================
Files 28 31 +3
Lines 1964 2164 +200
========================================
+ Hits 1709 1896 +187
- Misses 255 268 +13
|
…tection is at end of video
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Comments from synchronous code review
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Docs seem great—just one thought on a clarifying intro sentence!
All PR comments have been addressed. Checked memory usage with scalene and confirmed our predictions are within 0.1 of the competition code, often times closer to a difference of 0.03. This is likely because the competition code does some writing out and reading in of frames with open cv and also uses albumentations to resize (which uses open cv under the hood). We use torchvision transforms instead. Distances are usually measured in increments of 0.5 so these differences don't seem problematic. Tests are passing locally so I need to look into why they're failing on github. @pjbull if you have a moment to give the diff a quick read as a backstop, that'd be great. Here's the link |
This implementation takes in a folder of videos (or csv with video filepaths) and outputs a csv of distance estimates for each frame (and detection).
For frames with no detection, distance is null. If there are multiple detections in that frame, there is one line per detection. For example
Not included in this PR:
Notes:
Closes https://github.com/drivendataorg/pjmf-zamba/issues/57
Remaining to do: