Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Switch to pyproject.toml-based build #262

Merged
merged 12 commits into from
Mar 6, 2023
Merged

Switch to pyproject.toml-based build #262

merged 12 commits into from
Mar 6, 2023

Conversation

ejm714
Copy link
Collaborator

@ejm714 ejm714 commented Mar 3, 2023

setup.py commands have been deprecated, so let's move to a pyproject.toml based build

Bonus fixes

  • use the "paths" option to tell mkdocstrings where to find modules instead of installing the package. This makes the test matrix run about 10 min faster overall.
  • pip install pytorchvideo instead of using direct reference

@netlify
Copy link

netlify bot commented Mar 3, 2023

Deploy Preview for silly-keller-664934 ready!

Name Link
🔨 Latest commit 3e526b1
🔍 Latest deploy log https://app.netlify.com/sites/silly-keller-664934/deploys/64064f00d44183000897e5cd
😎 Deploy Preview https://deploy-preview-262--silly-keller-664934.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site settings.

@ejm714 ejm714 requested a review from jayqi March 3, 2023 20:54
@github-actions
Copy link
Contributor

github-actions bot commented Mar 3, 2023

@codecov-commenter
Copy link

codecov-commenter commented Mar 3, 2023

Codecov Report

Merging #262 (8f0b35f) into master (e9a28b9) will decrease coverage by 0.1%.
The diff coverage is 100.0%.

Additional details and impacted files
@@           Coverage Diff            @@
##           master    #262     +/-   ##
========================================
- Coverage    87.6%   87.6%   -0.1%     
========================================
  Files          32      26      -6     
  Lines        2175    2155     -20     
========================================
- Hits         1907    1889     -18     
+ Misses        268     266      -2     
Impacted Files Coverage Δ
zamba/version.py 100.0% <100.0%> (ø)
zamba/__main__.py
zamba/models/__init__.py
zamba/__init__.py
zamba/models/densepose/__init__.py
zamba/object_detection/__init__.py
zamba/models/depth_estimation/__init__.py

@jayqi
Copy link
Member

jayqi commented Mar 3, 2023

The error in the CI failure

No module named build

needs

python -m pip install --upgrade pip build

instead of

python -m pip install --upgrade pip setuptools wheel

@ejm714
Copy link
Collaborator Author

ejm714 commented Mar 3, 2023

python -m pip install --upgrade pip build

Another option is to do pip install -r requirements-dev.txt as build is contained there and will install everything needed for the tests. Any preference @jayqi?

@jayqi
Copy link
Member

jayqi commented Mar 3, 2023

I don't have a strong preference there. Given that that part of the workflow only runs the build and doesn't run the tests, it would be faster if it didn't need to install dependencies that aren't needed for building.

@ejm714
Copy link
Collaborator Author

ejm714 commented Mar 4, 2023

@jayqi this is ready for your review now

Copy link
Member

@jayqi jayqi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good. Just one note about the link names.

pyproject.toml Outdated Show resolved Hide resolved
@ejm714 ejm714 merged commit a49b0d7 into master Mar 6, 2023
@ejm714 ejm714 deleted the pyproject-toml-build branch March 6, 2023 20:38
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants