-
Notifications
You must be signed in to change notification settings - Fork 27
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Switch to pyproject.toml-based build #262
Conversation
✅ Deploy Preview for silly-keller-664934 ready!
To edit notification comments on pull requests, go to your Netlify site settings. |
Codecov Report
Additional details and impacted files@@ Coverage Diff @@
## master #262 +/- ##
========================================
- Coverage 87.6% 87.6% -0.1%
========================================
Files 32 26 -6
Lines 2175 2155 -20
========================================
- Hits 1907 1889 -18
+ Misses 268 266 -2 |
The error in the CI failure
needs python -m pip install --upgrade pip build instead of python -m pip install --upgrade pip setuptools wheel |
Another option is to do |
I don't have a strong preference there. Given that that part of the workflow only runs the build and doesn't run the tests, it would be faster if it didn't need to install dependencies that aren't needed for building. |
@jayqi this is ready for your review now |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good. Just one note about the link names.
setup.py
commands have been deprecated, so let's move to apyproject.toml
based buildBonus fixes