fix: forwaring dependencies within useLiveQuery #2652
Conversation
Add support for dynamic query dependencies in hooks
This update enables the use of dynamic values in query conditions within hooks, ensuring that queries are properly updated when their dependencies change.
Example
Using dynamic values in the where clause:
```ts
const todos = useLiveQuery(
db.query.todos.findMany({
where: between(schema.todos.created_at, from, to),
})
)
```
This enhancement is particularly useful for scenarios where the query depends on a set of changing dependencies, allowing for more flexible and responsive data fetching.
| @@ -43,7 +44,7 @@ export const useLiveQuery = <T extends Pick<AnySQLiteSelect, '_' | 'then'> | SQL | |||
| return () => { | |||
| listener?.remove(); | |||
| }; | |||
| }, []); | |||
| }, deps); | |||
There was a problem hiding this comment.
Isn't [query] enough?
It could be then automatically handled for everyone.
There was a problem hiding this comment.
wouldn't the query be referencing a new object on each re-render?
There was a problem hiding this comment.
Here's a simple example demonstrating how adding the deps array allows for more granular control over the re-execution of a query.
If you only pass the query, it will change with every re-render of the component. However, by specifying a separate dependency, the query will update only when necessary.
There was a problem hiding this comment.
Oh yes of course it would be better!
It would avoid wrapping the query in a useCallback before passing it to useLiveQuery
|
@anstapol Thanks a lot! I'll merge this one, but could you please use the dprint formatter and push the changes so all the checks will pass? |
|
@AndriiSherman any chance to merge and release this? |
Done! Anything else missing? |
Add support for dynamic query dependencies in hooks
This update enables the use of dynamic values in query conditions within hooks, ensuring that queries are properly updated when their dependencies change.
Example
Using dynamic values in the where clause:
This enhancement is particularly useful for scenarios where the query depends on a set of changing dependencies, allowing for more flexible and responsive data fetching.
Resolves #2651