Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Added AWS codecommit support using access & secret keys #36

Merged
merged 3 commits into from
Feb 5, 2021

Conversation

shubham149
Copy link
Contributor

No description provided.

@shubham149 shubham149 merged commit a0b9eeb into master Feb 5, 2021
@tboerger
Copy link

tboerger commented Feb 9, 2021

The AWS CLI is a simple Python tool, right? And just for that we got GLIBC installed now, which is also not really supported by Alpine officially? Sounds like a really bad move, especially for such a core plugin like this one.

@shubham149
Copy link
Contributor Author

shubham149 commented Feb 10, 2021

@tboerger I was not able to find a way to install aws cli v2 using pip. Pip install is available only for aws cli v1 version. Installation guide for aws cli on linux: https://docs.aws.amazon.com/cli/latest/userguide/install-cliv2-linux.html

@tboerger
Copy link

Looking at the conversation at aws/aws-cli#4947 it sounds even more like a bad idea to install v2 CLI at all. If you really must install v2 I would welcome more something like a manual installation:

apk update && apk add git groff python3 python3-dev py3-pip py3-six py3-urllib3 py3-colorama build-base libffi-dev openssl-dev && \
  pip install git+git://github.com/aws/aws-cli.git#2.1.25 && \
  apk del python3-dev py3-pip build-base libffi-dev openssl-dev && \
  rm -rf /var/cache/apk/*

But as far as I read all of that the v1 published to PyPi or available as Alpine package should be totally fine until AWS is providing proper packaging for Alpine/Musl. Adding Glibc to an Alpine image really sucks pretty hard.

@shubham149
Copy link
Contributor Author

@tboerger I have created a PR #37 to use pip for installing aws cli v1 version. Looks like aws codecommit git clone works with aws cli v1 as well.

@tboerger
Copy link

In case of using v1 you could also just use the alpine package for it :)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants