-
Notifications
You must be signed in to change notification settings - Fork 59
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Support for getting annotations from docstrings #103
Comments
I wonder if the right thing to do isn't for you to just fork pyannotate? Since my retirement from Dropbox I simply don't have the time to review pyannotate contributions any more, and I believe the mypy team at Dropbox also doesn't have that much time to invest. |
That's an interesting idea. Alternatively, I could help you maintain this
project, if you were willing to take a leap of faith. I could get someone
from one of the other open source projects that I contribute to to vouch
for me, if it helps.
…On Sat, Apr 18, 2020 at 9:42 PM Guido van Rossum ***@***.***> wrote:
I wonder if the right thing to do isn't for you to just fork pyannotate?
Since my retirement from Dropbox I simply don't have the time to review
pyannotate contributions any more, and I believe the mypy team at Dropbox
also doesn't have that much time to invest.
—
You are receiving this because you authored the thread.
Reply to this email directly, view it on GitHub
<#103 (comment)>,
or unsubscribe
<https://github.com/notifications/unsubscribe-auth/AAAPOE56APDVC2XFISE4NWDRNJ6M7ANCNFSM4MLP35AQ>
.
|
Well, this repo is owned by Dropbox, and I am no longer a Dropbox employee, so l cannot merge anything. Hence my suggestion to fork. |
Also, I've seen your contributions and I have no doubt about your skills or reliability. I suspect that Dropbox will be happy to see this project forked to get new energy and features into it! |
I'd hate to fork the project if we can get some momentum going here, and also I don't really want to be on the hook for the runtime part of the project, which I have very little interest in. My plan is to submit a series of PRs here for the issues that I created, and if they get merged then great, otherwise, I'll create a fork of the project under a new name, likely without the runtime part. Thanks for the guidance. And for.. y'know... python :) |
From the resounding silence you can draw your own conclusions. I hope your fork takes flight! |
Hi, me again. I created a tool, called
doc484
much likepyannotate
, for adding type comments based on docstrings. When I created my tool I was aware ofpyannotate
but assumed it just about generating annotations from types captured at runtime. Now that I realize it's really two separate tools, I think there are a lot of great features that could be added topyannotate
to make it a one-stop shop for generating/modifying type annotations.doc484
is also implemented usinglib2t3
and would be incredibly easy to add topyannotate
. It implies some additional features, like the ability to specify a fixer that should be considered a source of truth and should thus overwrite existing annotations if they are out of date (and dealing with the ramifications of that in a multi-fixer scenario).Let me know what you think.
The text was updated successfully, but these errors were encountered: