[jvm] Params to include sync info in thread dump. #1304
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
The failed test in Travis is not related to my change, that failed before, i.e. https://travis-ci.org/dropwizard/metrics/builds/369903978?utm_source=github_status&utm_medium=notification. Am guessing it's flaky? |
decbis
changed the title
|
Yes, unfortunately it's an ongoing battle to make the tests stable on Travis... I've restarted the build. |
|
LGTM, thanks for contributing! |
|
@arteam Any particular objections to me (back)porting onto the 3.1 and/or 3.2 branches? |
|
Please see the disclaimer in README. The 3.1 and 3.2 branches are in maintenance mode, only bugfixes are ported. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Having control over including synchronization info allows using this method (and its wrappers, i.e. ThreadDumpServlet) in environments where getting object monitor and/or ownable synchronizer usage is not supported.
Also, in a few experiments, it can also speed things up, especially for large heaps.