Reporters: report Timer sums in the Timer duration units #1309
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Reporting sums for
Timer
s is very useful, however they are currently always reported in nanoseconds, instead of in theTimer
's duration units. This is because we inherit the handling ofgetSum
fromMeter
, where it has a slightly different meaning.There are a couple of unsatisfying bits:
JmxTimer
loses some precision in reporting the sum, because we want to be able to report fractional values, butJmxMeter
assumes that it can be represented as along
. We could probably just changeJmxMeter
to report adouble
.GraphiteReporter.reportTimer
delegates to areportMetered
, which will do the wrong thing with the sum.