Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[jvm] make OSGi Package-Import for com.sun.management optional #1317

Conversation

vorburger
Copy link
Contributor

@arteam arteam merged commit 8ec371e into dropwizard:4.1-development May 30, 2018
@arteam
Copy link
Member

arteam commented May 30, 2018

LGTM. I believe we use the com.sun.management package only in FileDescriptorRatioGauge, which is part of metrics-jvm, so it should be fine to make it optional.

@arteam
Copy link
Member

arteam commented May 30, 2018

@vorburger If you want, I can cut a 4.0.3 release with this change.

@vorburger
Copy link
Contributor Author

@arteam it would be very cool and much appreciated if you could cut a 4.0.3 release - we would test and use it!

@splatch
Copy link

splatch commented Jul 17, 2018

@arteam, @vorburger any plans to cut 4.0.3 any time soon? ;-) I've just hit this one.

@arteam
Copy link
Member

arteam commented Jul 18, 2018

Thanks for the reminder, I will cut a release today.

@splatch
Copy link

splatch commented Jul 19, 2018

@arteam thank you very much for cutting release ✋!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants