table limit range support #16
Conversation
|
@code2prog Thanks for the PR! Could you add some links to old issues/PRs to get some background? |
src/Mysqldump.php
Outdated
| return is_numeric($this->tableLimits[$tableName]) ? $this->tableLimits[$tableName] : false; | ||
| $v = false; | ||
| if (is_numeric($this->tableLimits[$tableName])) { | ||
| $v = is_numeric($this->tableLimits[$tableName]); |
There was a problem hiding this comment.
Should this return $this->tableLimits[$tableName]; instead returning true?
There was a problem hiding this comment.
It is possible that you are right. I'll check it on Monday and change it.
There was a problem hiding this comment.
@back-2-95 I changed it and added additional tests
0196b1b
There was a problem hiding this comment.
Code looks valid, I'll run the tests
|
Could you also update |
|
I will add it tomorrow morning and improve the code style |
|
@code2prog This is now good to go, merging. 👏 |
I added support for offset in table limit
sample usage:
$dump->setTableLimits([ 'table_name' => [10,200], ]);I think this may also be useful for other users. There have been several requests over the years to add this functionality.