Fix #17 - Virtual Blob Columns were not treated as virtual #19
Conversation
amenk
commented
Nov 15, 2022
•
amenk
commented
- Virtual columns have a special handling
- If there are such columns, we need to switch to complete inserts for the table and omit the virtual values in the INSERTs
- If a column is virtual and blob, due to an error in the if-priority it was no longer treated as virtual
- Additionally the complete-insert switching also affected consequent tables, this PR isolates this to affect only the current table with the virtual columns
* Backup and restore the complete-insert settings, so it affects only tables with virtual columns and not all following ones
|
Tests pass. So this is only for 5.7 ? Could you provide the background on the PR description what is done here and why. |
|
Actually I am not sure if it is only for 5.7 -- should probably apply to all versions with virtual fields Comment updated |
|
Aah, I just read the diffs and there was 5 and 7 used for ifs so I assumed. |
|
okay, looks like my tests just would run for >= 5.7 but I think that is okay, I copied that from the other tests with virtual columns |
|
@back-2-95 can it be merged or do you have any other comments? |
|
@amenk It's now merged. I'm not gonna do a release yet until I have tested this in real projects. |
|
@back-2-95 okay, cool, keep me posted :-) |
|
Did you have a chance to test in a real project, yet? See also Smile-SA/gdpr-dump#79 |
|
Hi @amenk not yet but I created a patch release https://github.com/druidfi/mysqldump-php/releases/tag/1.0.2 |
