Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix typo #41

Closed
wants to merge 1 commit into from
Closed

Fix typo #41

wants to merge 1 commit into from

Conversation

staabm
Copy link

@staabm staabm commented Feb 29, 2024

one less space per row in the dump can make a considerable difference in file-size

one less space per row in the dump can make a considerable difference in file-size
@back-2-95 back-2-95 mentioned this pull request Mar 1, 2024
@back-2-95
Copy link
Member

Not totally sure, but this seems to break tests when native mysqldump came with MariaDB.

@staabm
Copy link
Author

staabm commented Mar 1, 2024

I see. Should I adjust the tests or is it not acceptable?

@back-2-95
Copy link
Member

If you can find the reason why this happens, please do. Tests generate native mysqldumps and then diff it with dumps done with the library. So it might be that native mysqldump gives two spaces there on some cases (mariadb?)

@staabm
Copy link
Author

staabm commented Mar 1, 2024

I will have a look. Please go ahead with the other things in the meantime and don't let it block a possible release

@staabm staabm closed this Mar 1, 2024
@staabm staabm deleted the patch-3 branch March 1, 2024 18:50
@staabm
Copy link
Author

staabm commented Mar 3, 2024

lets see whether I am able to contribute the change to mysql: mysql/mysql-server#524 ;).

I guess they will not accept the change, or it will take years to get into the wild... time will tell.
wish me luck.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants