Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Deprecate PHP 7.1 #518

Merged
merged 5 commits into from
Sep 20, 2019
Merged

Deprecate PHP 7.1 #518

merged 5 commits into from
Sep 20, 2019

Conversation

MPParsley
Copy link
Contributor

PHP 7.1 is no longer supported, let's remove it.

See https://www.php.net/supported-versions.php

@MPParsley MPParsley changed the title deprecate PHP 7.1 Deprecate PHP 7.1 Sep 11, 2019
MPParsley
MPParsley commented Sep 11, 2019
View reviewed changes
.travis.yml Outdated Show resolved Hide resolved
MPParsley
MPParsley commented Sep 11, 2019
View reviewed changes
composer.json Outdated Show resolved Hide resolved
RobLoach
RobLoach approved these changes Sep 18, 2019
View reviewed changes
Copy link

@RobLoach RobLoach left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Likely a good call, thanks!

@webflo webflo merged commit 5085410 into drupal-composer:8.x Sep 20, 2019
@webflo
Copy link
Member

webflo commented Sep 20, 2019

Thanks for the PR!

@MPParsley MPParsley deleted the patch-3 branch September 20, 2019 08:29
@PetersRicardo
Copy link

PHP 7.1 is no longer supported, let's remove it.

See https://www.php.net/supported-versions.php

This is not true yet, security support is maintained till 01-12-2019 the next drupal release still falls within this time frame (and will support 7.1 as far as I can tell).

Is this intended?

@goba
Copy link

goba commented Sep 20, 2019

This is a bit heavy handed. Since this package is the official suggested way to install Drupal with composer (https://www.drupal.org/docs/develop/using-composer/using-composer-to-install-drupal-and-manage-dependencies) it would be useful if the official version constraints would be followed. Drupal 8.8 does not even require PHP 7.1 yet let alone a minimum of 7.2.

webflo added a commit that referenced this pull request Sep 20, 2019
@webflo
Revert "Deprecate PHP 7.0 and 7.1 (#518)"
6de5b3a 
This reverts commit 5085410.
@webflo webflo mentioned this pull request Sep 20, 2019
Merged
webflo added a commit that referenced this pull request Sep 21, 2019
@webflo
Issue #518: Bump minimum php version to 7.0.8
a49e205
@webflo
Copy link
Member

webflo commented Sep 21, 2019

Thanks for your feedback. I reverted the change and we will use 7.0.8 as the new minimum.

omahm added a commit to dof-dss/nicsdru_cybersecurity that referenced this pull request Oct 2, 2019
@omahm
Update composer.json
a0ac089 
Reverting PHP 7.2 requirement, please see drupal-composer/drupal-project#518 (comment)
@tormi tormi mentioned this pull request Oct 8, 2019
Merged
@j3ll3nl j3ll3nl mentioned this pull request Oct 22, 2019
Closed
dannylamb pushed a commit to islandora-deprecated/drupal-project that referenced this pull request Jan 2, 2020
@elizoller @weitzman
@zaporylie @morenstrat @webflo @rodrigoaguilera @milkovsky @mxr576 @grasmash @andypost @hansfn @MPParsley @petk @gagarine @foxtrotcharlie @greg-1-anderson @paulvandenburg @dannylamb
Update to Drupal 8.8.1 (#34)
b802bb3 
* Honor .env files and suggest usage (drupal-composer#351)

* Remove extra whitespace (drupal-composer#371)

* Updated argument name

* Bump minimal version

* Bump minimal version to 8.5.3

* Fix installer path for drush commandfiles.

* Update drupal-composer/drupal-scaffold

drupal-composer/drupal-scaffold is a full featured plugin and provides its own command.

* Fix tests on Travis CI (drupal-composer#405)

* Copy the editor config and gitattributes from drupal to the root. (drupal-composer#404)

* Remove "drupal-scaffold" from scripts (drupal-composer#275)

* Fix typo in README.md

* Remove unused use statement. (drupal-composer#406)

* Adjust default core patch level to -p2. (drupal-composer#418)

* Bump minimum required composer-patches version to support default patch level (drupal-composer#410)

* Update composer.json to require latest stable version of Drupal (drupal-composer#424)

* Require zaporylie/composer-drupal-optimizations (drupal-composer#442)

* Issue drupal-composer#408: Bump minimum PHP version to 5.6

* Removing redundant "--stability dev" from installation command (drupal-composer#450)

Fixes drupal-composer#449.

* Added "composer-exit-on-patch-failure": true option to composer.json (drupal-composer#420)

* Sync new lines at the end of the files (drupal-composer#453)

* Quote wildcards to avoid issues in some shells (drupal-composer#456)

* Add PHP 7.3 to Travis CI (drupal-composer#476)

* Change createRequiredFiles messages to reflect what occured (drupal-composer#467)

* Drop PHP 5.6 testing (drupal-composer#489)

* Bump minimum version to 8.7.0 (drupal-composer#488)

* Update .travis.yml

* Deprecate PHP 7.0 and 7.1 (drupal-composer#518)

* Revert "Deprecate PHP 7.1" (drupal-composer#521)

This reverts commit 5085410.

* Issue drupal-composer#518: Bump minimum php version to 7.0.8

* Update CI to Ubuntu 18.04 (drupal-composer#520)

* Revert "Update CI to Ubuntu 18.04" (drupal-composer#526)

This reverts commit ee5bf36.

* Add 'contrib' to Drush commandfile installer path (drupal-composer#525)

* Prefer usage of && operator instead of "and" (drupal-composer#530)

* update to drupal 8.8.0

* replace webflo/drupal-core-require-dev with drupal/core-dev

* Use scaffold plugin and composer packages from Drupal core 8.8.0 (drupal-composer#522)

* Issue drupal-composer#539: Remove deprecated CONFIG_SYNC_DIRECTORY

* update to 8.8.1

Co-authored-by: Moshe Weitzman <[email protected]>
Co-authored-by: Jakub Piasecki <[email protected]>
Co-authored-by: Markus Orenstrat <[email protected]>
Co-authored-by: Florian Weber <[email protected]>
Co-authored-by: Rodrigo <[email protected]>
Co-authored-by: Norman Kämper-Leymann <[email protected]>
Co-authored-by: Alex Milkovskyi <[email protected]>
Co-authored-by: Dezső BICZÓ <[email protected]>
Co-authored-by: Matthew Grasmick <[email protected]>
Co-authored-by: Andy Postnikov <[email protected]>
Co-authored-by: Hans Fredrik Nordhaug <[email protected]>
Co-authored-by: Maarten Segers <[email protected]>
Co-authored-by: Peter Kokot <[email protected]>
Co-authored-by: Simon Perdrisat <[email protected]>
Co-authored-by: Charles Tanton <[email protected]>
Co-authored-by: Greg Anderson <[email protected]>
Co-authored-by: Paul <[email protected]>
zanvidmar added a commit to oscarsergeant/drupal-project that referenced this pull request Feb 12, 2020
@zanvidmar @MPParsley
@webflo @greg-1-anderson @paulvandenburg
update 8x branch (#4)
5c633a1 
* Deprecate PHP 7.0 and 7.1 (drupal-composer#518)

* Revert "Deprecate PHP 7.1" (drupal-composer#521)

This reverts commit 5085410.

* Issue drupal-composer#518: Bump minimum php version to 7.0.8

* Update CI to Ubuntu 18.04 (drupal-composer#520)

* Revert "Update CI to Ubuntu 18.04" (drupal-composer#526)

This reverts commit ee5bf36.

* Add 'contrib' to Drush commandfile installer path (drupal-composer#525)

* Prefer usage of && operator instead of "and" (drupal-composer#530)

* Use scaffold plugin and composer packages from Drupal core 8.8.0 (drupal-composer#522)

* Issue drupal-composer#539: Remove deprecated CONFIG_SYNC_DIRECTORY

Co-authored-by: Maarten Segers <[email protected]>
Co-authored-by: Florian Weber <[email protected]>
Co-authored-by: Greg Anderson <[email protected]>
Co-authored-by: Paul <[email protected]>
shrop pushed a commit to shrop/drupal-project that referenced this pull request Apr 11, 2020
@MPParsley @shrop
Deprecate PHP 7.0 and 7.1 (drupal-composer#518)
dcc3651
shrop pushed a commit to shrop/drupal-project that referenced this pull request Apr 11, 2020
@webflo @shrop
Issue drupal-composer#518: Bump minimum php version to 7.0.8
131819c
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@RobLoach RobLoach RobLoach approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@MPParsley @webflo @PetersRicardo @goba @RobLoach