drush sql-query should exit with failure status if query fails

[rfay]

Currently, drush sql-query exits with a 0 even if there was an error in the query:

[rfay@dev-web11 current]$ drush sqlq 'select * from nothing;'
ERROR 1146 (42S02) at line 1: Table 'xxx_dev.nothing' doesn't exist
[rfay@dev-web11 current]$ echo $?
0

I think it would be useful to all of us if it returned an error status in a case like this.

Thanks!

[greg-1-anderson]

Above are the commits to master and 8.x-6.x. Did not backport to 7.x-5.x as an overly-cautious nod to backwards compatibility. I think this could go in 5.x if anyone felt strongly that it shoudl.

[rfay]

I would very much like it to go into 5.x, if that would be possible.

[rfay]

But wow, what amazing responsiveness! Thanks!

[greg-1-anderson]

Backported to 7.x-5.x. Seems like a pretty slim chance that anyone would have a script broken because they expected the script to keep running after a failed sql-query command. If anyone has any problems with this, please re-open, or just back out the change.

[weitzman]

Actually, that _drush_sql_query is an API function used elsewhere (I think). We should probably throw an error in the command callback, drush_sql_query().

[greg-1-anderson]

You're right, I put that in the wrong place. I fixed it in master, 6.x and 5.x, but forgot to mention this issue in the commit comment.

The commit on master was b8522b3

[plach79]

I'm still experiencing this on 8.x, apparently drush_sql_cli() does not set an explicit error when the process fails and returning FALSE is not enough to set a non-zero exit status.