-
-
Notifications
You must be signed in to change notification settings - Fork 1.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix #2106. Port help commands to Annotated. #2670
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
I'm now reusing HelpDocument from Annotated-Command project. Drush is supplying its own formatter for CLI presentation of help. Ping @greg-1-anderson for input on the list below. Bugs
Nice to have
|
Also abbreviate a few option descriptons.
Still lamely returning an array.
4 tasks
weitzman
changed the title
[WIP] Fix #2106. Port help commands to Annotated.
Fix #2106. Port help commands to Annotated.
Mar 27, 2017
mikeker
pushed a commit
to mikeker/drush
that referenced
this pull request
Aug 10, 2017
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
A start at porting help and helpsingle commands. I'm happy with the output of Console's list command (only gripe is that it wants to list all global options which is a currently long list in our case.)
The output appears to need a colspan for the category titles. How to do this with Consolidated/OutputFormatters? Or should I bypass that and Output via Console's Table class directly? Ping @greg-1-anderson