Fix wrong state mapping in config:status command #3053
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Chi-teck
changed the title
weitzman
reviewed
Oct 11, 2017
| 'update' => 'Only in sync dir', | ||
| 'delete' => 'Different', | ||
| 'update' => 'Different', | ||
| 'delete' => 'Only in sync dir', |
There was a problem hiding this comment.
Is there any chance that Create and Delete are flipped? In the context of an import, if a file is only in sync dir that will lad to a 'create', not a 'delete'.
There was a problem hiding this comment.
I suppose it only depends on the order of parameters passed to StorageComparer constructor.
Drush passes active storage in first parameter, so it is considered as source (storage object used to read configuration).
https://github.com/drush-ops/drush/blob/9.0.0-beta7/src/Drupal/Commands/config/ConfigCommands.php#L320
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
"Different" state should stand for "update" operation and be displayed in yellow to match
drush cex/drush cimcommands.