Check to see if Drush extensions are compatible with the current version. #3189
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
greg-1-anderson
force-pushed
the
extension-version-check
branch
from
261735a to
98f3c36
Compare
|
Ideally we'd factor out some of this code into a separate class, maybe do some DI. This should be good enough for rc1, I think, though. Please review and LMK if you concur. |
|
Code looks good. Extra section needs to be added to command authoring docs and DrushAliasFile generator. These can be a followup. |
|
Great. I'll merge this in now & update documentation as soon as I get a chance. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Still needs to check the Drush version in a meaningful way.