Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Move Migrate Run commands in Drush core #4606

Merged
merged 54 commits into from
Jan 3, 2021

Conversation

claudiu-cristea
Copy link
Member

@claudiu-cristea claudiu-cristea commented Dec 15, 2020

Fixes #2926. Development started in #3402.

Status of porting changes from Migrate Tools since #3402

Follow-ups

Copy link
Member

@weitzman weitzman left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Quick initial review. Thanks for your hard work on this.

docs/migrate.md Outdated Show resolved Hide resolved
includes/migrate_runner.inc Outdated Show resolved Hide resolved
includes/migrate_runner.inc Outdated Show resolved Hide resolved
src/Commands/core/DocsCommands.php Outdated Show resolved Hide resolved
src/Drupal/Commands/core/MigrateRunnerCommands.php Outdated Show resolved Hide resolved
Copy link
Member

@weitzman weitzman left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Should we add a composer conflict with migrate_tools module <=5? Would prevent some chaos around duplicate commands being declared.

includes/migrate_runner.inc Outdated Show resolved Hide resolved
src/Drupal/Commands/core/MigrateRunnerCommands.php Outdated Show resolved Hide resolved
src/Drupal/Commands/core/MigrateRunnerCommands.php Outdated Show resolved Hide resolved
src/Drupal/Commands/core/MigrateRunnerCommands.php Outdated Show resolved Hide resolved
src/Drupal/Commands/core/MigrateRunnerCommands.php Outdated Show resolved Hide resolved
tests/functional/MigrateRunnerTest.php Show resolved Hide resolved
src/Drupal/Commands/core/MigrateRunnerCommands.php Outdated Show resolved Hide resolved
@claudiu-cristea
Copy link
Member Author

Should we add a composer conflict with migrate_tools module <=5? Would prevent some chaos around duplicate commands being declared.

Good point. I've added also "drupal/migrate_run": "*" as this is a full replacement.

src/Commands/core/DocsCommands.php Outdated Show resolved Hide resolved
src/Drupal/Commands/core/MigrateRunnerCommands.php Outdated Show resolved Hide resolved
src/Drupal/Commands/core/MigrateRunnerCommands.php Outdated Show resolved Hide resolved
@weitzman weitzman merged commit 302bda8 into drush-ops:10.x Jan 3, 2021
@weitzman
Copy link
Member

weitzman commented Jan 3, 2021

Thanks @claudiu-cristea. Great work.

@claudiu-cristea claudiu-cristea deleted the migrate-runner branch January 3, 2021 10:08
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Add migrate_run instead of migrate_tools
2 participants