Convert commands to classes. #612
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Thats generally the idea, yes. However, Symfony Console already provides a framework and we might benefit from just using that. There are some open questions though. We could use your input at #88 |
|
Dupe |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is the beginning of a proof of concept for converting Drush commands to classes per #532 (comment). I'm beginning by creating a
CommandInterface, imagining that individual commands would implement it. I started by just creating a method for each of the major elements returned byCOMMANDFILE_drush_command()and one for each of the command hooks. Does this seem like the right approach? Should I continue?